Picture in loading-screen does not sit on the bottom left

Bug #1801340 reported by Toni Förster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

The windmill that is displayed during the loading, sometimes isn't to scale. I', not sure whether this is intended or a bug. Please have a look at the attached screenshot (taken in Fullscreen) and decide for youreself.

Tags: ui

Related branches

Revision history for this message
Toni Förster (stonerl) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

This is intentional, because scaling up makes for bad graphics quality.

It should be sitting on the bottom left though.

tags: added: ui
Changed in widelands:
milestone: none → build20-rc1
Revision history for this message
Toni Förster (stonerl) wrote :

Sometimes it does sit on the bottom left, but not always (see the screenshot attached to this comment). It seems as if it's using the windowed resolution when it does not sit in the bottom left. (Windowed Resolution is 800x600) instead of the Fullscreen.

summary: - Picture in loading-screen not to scale
+ Picture in loading-screen does not sit on the bottom left
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
status: New → In Progress
Revision history for this message
GunChleoc (gunchleoc) wrote :

I can't reproduce this. If you want to have a try at fixing this yourself, start from ui_basic/progresswindow.cc

Changed in widelands:
status: In Progress → New
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
Toni Förster (stonerl) wrote :

Had a look at the file and found the cause in Line 87.

if (!file_name.empty() && g_fs->file_exists(file_name)) {
    add_overlay_image(
        file_name, FullscreenWindow::Alignment(UI::Align::kCenter, UI::Align::kCenter));
} else {
    add_overlay_image("images/loadscreens/progress.png",
        FullscreenWindow::Alignment(UI::Align::kLeft, UI::Align::kBottom))
}

Is there a reason why the background is centered when a filename is provided? It seems as if is switching between the if and else statement on my system.

Toni Förster (stonerl)
Changed in widelands:
assignee: nobody → Toni Förster (stonerl)
GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: Toni Förster (stonerl) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.