Shading language version conversion to double fail
Bug #1797792 reported by
Jukka Pakarinen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Critical
|
Unassigned |
Bug Description
Widelands does not work with finnish language option but 'en_US' works fine.
./widelands --language=fi_FI
Last two lines from console:
Graphics: OpenGL: ShadingLanguage: "1.30" (1,00)
ERROR: Shading language version is too old!
I think that atof conversion depends on locale. Decimal separator is comma character in finnish which might be the problem. My first guess, but not absolutely sure about that.
I compiled Widelands from trunk, revno 8883, on Debian 9.5.
Related branches
lp:~widelands-dev/widelands/bug-1797792-shading-language-version-comparison
- Notabilis: Approve (diff, testing)
- GunChleoc: Needs Resubmitting
-
Diff: 89 lines (+42/-29)1 file modifiedsrc/graphic/gl/initialize.cc (+42/-29)
Changed in widelands: | |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
To post a comment you must log in.
Thanks for the bug report. /wl.widelands. org/forum/ topic/4237/ ?page=2# post-26398
We also got a related bug report on the forum for french locales:
https:/
atof() seems indeed to be the problem, I guess we have to replace it with something locale-independent.