Warnings for "on failure fail" while loading tribes
Bug #1791605 reported by
Benedikt Straub
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
During tribe loading on current trunk (bzr8819), I get these logs:
┃ Warehouses: 64ms
found "on ": parameters = "failure fail"
read handling method for result 1: 0, parameters = "", reached_end = 1
found "on ": parameters = "failure fail"
read handling method for result 1: 0, parameters = "", reached_end = 1
found "on ": parameters = "failure fail"
read handling method for result 1: 0, parameters = "", reached_end = 1
found "on ": parameters = "failure fail"
read handling method for result 1: 0, parameters = "", reached_end = 1
┃ Productionsites: 1860ms
Related branches
lp:~widelands-dev/widelands/bug-1791605-on-failure-fail
- kaputtnik (community): Approve
-
Diff: 21 lines (+0/-4)1 file modifiedsrc/logic/map_objects/tribes/production_program.cc (+0/-4)
| Changed in widelands: | |
| status: | New → Triaged |
Revision history for this message
| Arty (artydent) wrote | #1 |
| Changed in widelands: | |
| status: | Triaged → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Just checked \src\logic\
Those aren't actual warnings, but neutral logs made while ProductionProgr
The logs are made when the lua files of the four shipyards are parsed (the only programs where "on <programm result> <handling method>" is actually used), and the logs just state that this construct was found and successfully parsed.
I guess generating those logs was part of some functionality testing or some bug search at some point, and then forgotten about.
I think the log generation can just be removed. If anything actually can't be properly parsed then exceptions are thrown with fitting messages, so those logs somewhat superfluous.