Appveyor glbinding incompatible with WL code

Bug #1789835 reported by hessenfarmer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

MSYS has upgraded the glbinding Version found by pacman on Appveyor to 3.0.2.1 which seems to have issues with the WL code. (was 2.1.4 previously whic just ran fine)

Short term solution could be to add an instruction to downgrade glbinding packet or use glew instead.

In the Long term the Problem has to be analyzed and fixed in the code imo.

Tags: windows

Related branches

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

ok I digged a little through the glbinding documentation.

made some changes to src/graphic/gl/initialize.cc and added the new headers to src/graphic/gl/system_headers.h

if it compiles I'll add the files as attachment

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

at least the changes compiled with my msys2 environment although I now have a final linking errror with icu but that might be unrelated. Here are my changes.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for looking in to this. Is there a reason that you're creating attachments instead of a branch?

tags: added: windows
Changed in widelands:
milestone: none → build20-rc1
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Mainly because I did my trials within an existing branch and had no time to properly branch one for this issue. It doesn't work at the moment either cause it has linking errors when finally linking the exe. The errors are related to the new aux namespace. But as I am afk from my dev machine I can't look into this until sunday. Probably it is recommendable to activate the old error handling again and delete the line with the aux:: function

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

The branch with the downgrade solution seems to work for the Moment being.

I found a possible solution for glbinding in this Project

https://github.com/Vita3K/Vita3K/commit/50d5f370ccb31f01931bbad8a61d56415bb26bf2#diff-a3d8e817ab0c2453cab1fd1f9a601e71

I will test this tonight

Revision history for this message
GunChleoc (gunchleoc) wrote :

We should also detect the Boost version properly rather than downgrading it on Appveyor. Let's get the dirty hack in first though to make sure we get it running again ASAP.

https://www.boost.org/doc/libs/master/libs/config/doc/html/boost_config/boost_macro_reference.html#boost_config.boost_macro_reference.boost_informational_macros

Changed in widelands:
status: New → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Confirmed
Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.