Activity log for bug #1767919

Date Who What changed Old value New value Message
2018-04-30 03:13:28 tamanegi bug added bug
2018-04-30 03:15:37 tamanegi description Training site messages like "upgrading soldier evade from level 0 to level 1" shown when hover on that site cannot be translated. Corresponding messages for production sites can be translated as expected. Widelands version: bzr8668 Platform: Debian testing In the beginning of constructor of TrainingSiteDescr class (src/logic/map_objects/tribes/trainingsite.cc), the second argument to the parent class constructor which seems to be a message context is empty. I guess it is the cause of this issue. : ProductionSiteDescr(init_descname, "", MapObjectType::TRAININGSITE, table, egbase), If I modify the second argument like this: : ProductionSiteDescr(init_descname, table.get_string("msgctxt"), MapObjectType::TRAININGSITE, table, egbase), the training site messages are translated as expected. Training site messages like "upgrading soldier evade from level 0 to level 1" shown when hover on that site cannot be translated. Corresponding messages for production sites can be translated as expected. Widelands version: bzr8668 Platform: Debian testing In the beginning of constructor of TrainingSiteDescr class (src/logic/map_objects/tribes/trainingsite.cc), the second argument to the parent class constructor which seems to be a message context is empty. I guess it is the cause of this issue.    : ProductionSiteDescr(init_descname, "", MapObjectType::TRAININGSITE, table, egbase), If I modify the second argument like this:    : ProductionSiteDescr(init_descname, table.get_string("msgctxt"), MapObjectType::TRAININGSITE, table, egbase), the training site messages are translated as expected.
2018-04-30 06:28:48 GunChleoc widelands: milestone build20-rc1
2018-04-30 06:28:50 GunChleoc widelands: assignee GunChleoc (gunchleoc)
2018-04-30 06:29:15 GunChleoc widelands: status New In Progress
2018-04-30 07:59:33 GunChleoc branch linked lp:~widelands-dev/widelands/bug-1767919-trainingsite-messages
2018-05-05 17:04:34 GunChleoc widelands: status In Progress Fix Committed
2018-05-05 17:04:36 GunChleoc widelands: assignee GunChleoc (gunchleoc)
2019-04-22 07:44:41 GunChleoc widelands: status Fix Committed Fix Released