widelands

Font of geologist messages not correctly handled

Bug #1767130 reported by tamanegi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned
widelands build20-rc1

Bug Description

Hello, I'm now working on Japanese translation of Widelands.
I found a bug about the font handling in geologist message.

In the attached screenshot, coal resource message is broken,
although the title is shown correctly in the message list
above.

Other messages can be displayed correctly.
For example, sentry and headquarter messages listed in the
screenshot can be shown nicely in Japanese. As far as I know,
only the geologist messages are affected.

If I change the default font setting in data/i18n/fonts.lua
(change font of sans, sans-bold, sans-italic etc. in default
 section to MicroHei, which includes Japanese), those
geologist messages can be shown in Japanese. So I consider
there is a problem in font selection in geologist messages.

Some other languages will be affected by this issue.
Please fix this...

Widelands version: bzr8654
Platform: Debian testing

Related branches

lp:~widelands-dev/widelands/bug-1767130-japanese
Widelands Developers: Pending requested
Diff: 77 lines (+11/-8)
4 files modified
src/graphic/text_layout.cc (+1/-1)
src/logic/cmd_luacoroutine.cc (+1/-3)
src/logic/map_objects/tribes/worker.cc (+6/-3)
src/wui/game_message_menu.cc (+3/-1)
Revision history for this message
tamanegi (tamanegi) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for reporting. We need to fix this for Build 20.

tags: added: internationalization
removed: translation
Changed in widelands:
milestone: none → build20-rc1
importance: Undecided → High
Revision history for this message
GunChleoc (gunchleoc) wrote :

Found it - we forgot to reformat the Geologists' messages to use the new font renderer. The old renderer can't handle multibyte strings properly. Looks like my version of the default fontset is covering the glyphs, so I never noticed.

Changed in widelands:
status: New → In Progress
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in r8688.

Since none of us can reproduce the problem, could you please test if it's working now, and reopen the bug if there is still a problem?

Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
tamanegi (tamanegi) wrote :

Yeah, the messages are shown correctly as in attached one.
Thank you very much for the quick fix!

Widelands version: r8692

(please remove the attachment if we should save disk space here.)

Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.