Codecheck: Interpretes comment as assignment

Bug #1766309 reported by Notabilis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Low
Unassigned

Bug Description

For some reason, this line:

  static const std::string INTERNET_GAME_SETUP = "SETUP"; // Map selection, ...

(Was in merge request as src/network/internet_gaming_protocol.h line 82)

Makes codecheck complain:

  const std::string must not be passed by value. Pass by reference!

Removing the comma fixes the issue.

Tags: codecheck
Revision history for this message
GunChleoc (gunchleoc) wrote :
Changed in widelands:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.