bidi.h: 'UnicodeString' does not name a type

[kaputtnik]

After updating some packages on my system i get an compile error in both debug and and release builds of current trunk. The error persists also after deleting the build directory:

In file included from /home/kaputtnik/widelands-repo/trunk/src/ui_fsmenu/options.cc:36:0:
/home/kaputtnik/widelands-repo/trunk/src/graphic/text/bidi.h:43:36: error: 'UnicodeString' does not name a type
 std::string icustring2string(const UnicodeString& convertme);
                                    ^~~~~~~~~~~~~
make[2]: *** [src/ui_fsmenu/CMakeFiles/ui_fsmenu_options.dir/build.make:63: src/ui_fsmenu/CMakeFiles/ui_fsmenu_options.dir/options.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:33389: src/ui_fsmenu/CMakeFiles/ui_fsmenu_options.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Upgraded packages (the ones i guess they could cause this error):

[2018-04-01 21:04] [ALPM] upgraded icu (60.2-1 -> 61.1-1)
[2018-04-01 21:04] [ALPM] upgraded boost-libs (1.66.0-1 -> 1.66.0-2)
[2018-04-01 21:04] [ALPM] upgraded boost (1.66.0-1 -> 1.66.0-2)

Full output of configure is attached.

[GunChleoc (gunchleoc)]

It's still in the same header: https://ssl.icu-project.org/apiref/icu4c/classicu_1_1UnicodeString.html

So this needs some digging into.

[kaputtnik (franku)]

The attached branch compiles fine here again. All i did was to add icu:: to the UnicodeString

https://bazaar.launchpad.net/~widelands-dev/widelands/bug_1760581-fix-UnicodeString/revision/8640#src/graphic/text/bidi.h

[GunChleoc (gunchleoc)]

Found it: "C++ call sites need to qualify ICU types explicitly, for example icu::UnicodeString, or do using icu::UnicodeString; where appropriate. If your code relies on the "using namespace icu;" that used to be in unicode/uversion.h, then you need to update your code."

http://site.icu-project.org/download/61#TOC-Migration-Issues

[GunChleoc (gunchleoc)]

Can you try if the attached branch fixes it?

[kaputtnik (franku)]

Since it is the same change that i did prior: Yes it compiles fine now, see #3 ;)

[GunChleoc (gunchleoc)]

You won the race then :)

I have deleted my branch and put yours up for review. I'll learn to refresh my browser next time.

[kaputtnik (franku)]

*lol*

But you got the explanation ;)

[GunChleoc (gunchleoc)]

Fixed in build20-rc1