Rework Atlantean Crystal Mine

[Teppo Mäenpää]

Atlantean marble mine works poorly when depleted. More poorly than the other tribes' mines, that is.

Ways to improve:
- Each work step only takes action, if the main output is needed
- The first mine-produce -cycle of each program produces at least one ware of needed type.

Not producing the needed ware right away lowers the percentage of success from 0.05 to 0.05^n, where n is the number of step that produces the needed ware. This is unfair, a five-percent success rate is big enough handicap.

See Forum ( https://wl.widelands.org/forum/topic/4212 ) for discussions.

[Teppo Mäenpää (kxq)]

I attach a simple save game with three Crystal mines and 1000 fooditems for easy testing.

Load save game, and observer the accumulation of granite and quartz. The difference between attached branch and current trunk describes the difference quite clearly.

[GunChleoc (gunchleoc)]

Those graphs look good ;)

[Teppo Mäenpää (kxq)]

Now the granite-cycle produces
granite:2
granite:2
granite
quartz

One could boost the empty mines a bit more, for example like this:
granite:3
granite
granite
quartz

This way, the behavior with non-depleted mines is the same (unless micromanaging), and mountain releases same amount of resources before depleting, but the empty-mine would be boosted a bit wrt others. I think that the mines would still not be too good, but this is subjective.

The branch, as it is now, fixes a real bug and should go to trunk in my opinion.

I am less sure if changes like drafted above should be done too.

[Teppo Mäenpää (kxq)]

Thanks.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1