Desync in Smugglers scenario
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
High
|
Unassigned |
Bug Description
I encountered a desync in the Smugglers scenario. It happens during the smuggling of wares.
I am attaching a savegame. Although it was created on a branch, the bug will also reproduce on trunk.
The bug was introduced somewhere between Build 18 and Build 19.
build18 6828
build19-rc1 8143
The problem is the random selection of wares - some shortened test output:
[Client]: sending timestamp: 2154276
Player: GunChleoc Warping ware: granite
[Client]: sending timestamp: 2156444
[Client]: sending timestamp: 2162867
Player: Player 2 Warping ware: granite
[Client]: sending timestamp: 2165167
Player: GunChleoc Warping ware: blackwood
[Client]: sending timestamp: 2167347
[Host]: Client 0: Time 2154276
Player: GunChleoc Warping ware: granite
[Host]: Client 0: Time 2156444
[Host]: Client 0: Time 2162867
Player: Player 2 Warping ware: granite
[Host]: Client 0: Time 2165167
Player: GunChleoc Warping ware: barbarians_bread
[Host]: Client 0: Time 2167347
Related branches
- Widelands Developers: Pending requested
-
Diff: 96 lines (+48/-20)1 file modifieddata/maps/MP_Scenarios/Smugglers.wmf/scripting/smuggling.lua (+48/-20)
- Klaus Halfmann: Approve (compile, review, testplay (osx, win10, linux))
-
Diff: 620 lines (+431/-102)4 files modifieddata/maps/MP_Scenarios/Smugglers.wmf/scripting/multiplayer_init.lua (+34/-63)
data/maps/MP_Scenarios/Smugglers.wmf/scripting/smuggling.lua (+142/-38)
data/maps/MP_Scenarios/Smugglers.wmf/scripting/starting_conditions.lua (+254/-0)
src/scripting/lua_game.cc (+1/-1)
description: | updated |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | New → In Progress |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | In Progress → Confirmed |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
The bug is already present in Build 19