Rephrase objective in Empire 2

[GunChleoc]

Rephrase the "Food For Your Miners" objective in the Empire 2 scenario.

Rules are roughly:

1. Always begin with a clear objective expressed in imperative.
2. Adress the player always with you, avoid we and our and so on.
3. Additional info and explanation can be given after the imperative or in an li_arrow item.

Are these rules documented on the wiki? We could have a general string desing page there.

[hessenfarmer (stephan-lutz)]

No I don't think they are documented. Venatrix and I were discussing my original wording in empire 4 and during the discussion she had very good reasons to implement these rules. They were that clear and good that I decided to rephrase the empire 3 objectives in this sense as well. I didn't have a look at the other tribes scenarios. But I really found it logical to implement them for all empire missions.
The best reason for doing so in my opinion was that objectives are a demand from the game to the player and adressing the player by an imperative in singular does make a lot of sense in my opinion.
So if you don't mind I'll grab trunk and rephrase the objective after having finished testing the frisians. I don't know how to add the "rules" to the wiki. But if you want them to be included in the wiki we should recheck all the scenarios to do so.
Perhaps you could contact Venatrix what is her opinion about that.

[GunChleoc (gunchleoc)]

You could add the info to the following page: https://wl.widelands.org/docs/wl/tutorial/

If the page should get too long, we can split it off afterwards.

I have also hooked the CampaignCreation page into https://wl.widelands.org/wiki/GettingStarted/

Another thing we should document is our policy on numbers ("2" vs. "two" etc.)

[kaputtnik (franku)]

I have also begun a more detailed wikipage for creating a scenario/campaign. The rules can also be added there?

https://wl.widelands.org/wiki/WikiSandbox/

[Venatrix (elisabeth)]

Yeah, well, sure, we should write the rules down somewhere to help writers to keep it consistent.

Rules regarding the numbers:

4. In the objective title write numerals to get them with one glance.
5. In the description text write numbers up to 12 in words, larger ones in numerals. At least that’s the German rule, I just hope it’s similar in English. Translators have to mind their own language’s rules of course.

Anything I forgot?

About where to add the rules: I guess I would go for the scenario tutorial or kaputtnik’s new page (or both, the text can be copied or linked).

@kaputtnik: I had a short look at your page and stumbled at the "story_script.lua" you mentioned there. I guess it’s just an example scenario thing, but in the campaign folders there is never such a file. Is that intended?

@GunChleoc: What’s a li_arrow item?

[kaputtnik (franku)]

While the name of the file doesn't matter, i had already changed the name this morning. Just to make it easier for beginners to compare with the implemented campaigns :-)

For the rules i am not confident anymore to add them to the wikipage. I didn't thought it would become that big. We should document them else where and link it from the wikipage.

[GunChleoc (gunchleoc)]

> (or both, the text can be copied or linked)

Linked please - copying will add too much of a maintenance burden, and eventually the 2 pages will diverge. I'd certainly be in favor of a general "string design" page that would cover the core UI strings as well as scenario scripting.

li_arrow is a convenience function to create a list item with an arrow bullet instead of a round bullet point.

[hessenfarmer (stephan-lutz)]

Ok I started to work on this bug should I check the other scenarios for violence of the 5 rules as well?

[GunChleoc (gunchleoc)]

Sure, consistency is always good :)

[hessenfarmer (stephan-lutz)]

Ok I will do so. Probably it would be a good idea to have a commit for every changed file then to be able to undo the changes.

[GunChleoc (gunchleoc)]

Sounds good to me :)

[hessenfarmer (stephan-lutz)]

Hi,
Did empire 02 which was not tricky.

In the barbarian Campaign I had to change a lot. Could you please have a look on Bar01 texts file if I am working in the right direction?

[GunChleoc (gunchleoc)]

Please link your branch to this bug

[hessenfarmer (stephan-lutz)]

Ok done. I thought linking the bug to the branch would be sufficient. Diddn't know it is possible the other way round as well.

[GunChleoc (gunchleoc)]

It doesn't matter which way around you like them - it's just 2 points of access in the Launchpad interface for the same thing.

I had a quick look at the Barbarian changes and they look good to me in principle. I'd like to postpone them until after Bild20 though to reduce the workload for translators - we already have quite a lot to do with 4 new scenarios and a new tribe.

[hessenfarmer (stephan-lutz)]

Ok so I will change the Barbarian 02 and the Atlantean 01 objectives in the current manner as well.
I think the workload by this change isn't that big because I changed only the objectives and I kept as much of the strings as I could. Only thing is I splitted some strings which makes it easier for translators to do their job. Anyhow If you decide to postpone this it's ok for me also. I will finish it now to due to not having it in an open state.

What abaout the addition of the Lore for Barbarian's would you like to postpone that as well? That would be a pitty.

[GunChleoc (gunchleoc)]

Yes, I'd like to postpone that as well. I'm personally getting a bit crazy with my translation workload for diverse projects at the moment, so the relief would be very welcome.

Splitting strings always makes things easier for the future, but the translation memory can fail to recognize all of them, so it can actually add workload for those who have already translated them. I did a lot of splitting to make strings shorter when I did my big overhaul a few years back, and it did take some fiddling and copy/paste from the previous version to restore some of those strings.

Finishing it now while you're already in the mindset is a good idea. I have about 20 or so finished branches waiting for a review slot and are now postponed for Build 21 ;)

[hessenfarmer (stephan-lutz)]

I have rethought my position on this.

I would suggest to revert the branch to only have the empire changes in which makes the empire campaign consistent. As the other campaigns are somewhat different as I learned from the current translation activities, and we don't have a styleguide yet, we should consider carefully whether to change anything in the other campaign. this can easily be done in the future after having a styleguide. the samll empire changes (it is only 7 strings could be merged into b20 instead) what do you think?

[GunChleoc (gunchleoc)]

Yes, 7 strings of small changes will be fine :)

[GunChleoc (gunchleoc)]

Fixed in build20-rc1