Unable to compile build19 anymore regarding netclient

[kaputtnik]

Because on arch linux the boost package is updated regularly i have to compile widelands from scratch (by removing the build directory) from time to time. Now i encountered this compile error:

[ 15%] Building CXX object src/network/CMakeFiles/network.dir/netclient.cc.o
In file included from /home/kaputtnik/Quellcode/widelands-repo/build19/src/scripting/lua_errors.h:25:0,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/scripting/lua_table.h:32,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/logic/map_objects/tribes/tribe_basic_info.h:29,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/logic/game_settings.h:28,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/network/netclient.h:25,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/network/netclient.cc:20:
/home/kaputtnik/Quellcode/widelands-repo/build19/src/network/network.h: In Elementfunktion »virtual const char* ProtocolException::what() const«:
/home/kaputtnik/Quellcode/widelands-repo/build19/src/base/wexception.h:63:90: Warnung: throw wird immer terminate() aufrufen [-Wterminate]
 #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code was reached.")
                                                                                          ^
/home/kaputtnik/Quellcode/widelands-repo/build19/src/network/network.h:184:3: Anmerkung: bei Substitution des Makros »NEVER_HERE«
   NEVER_HERE();
   ^~~~~~~~~~
In file included from /home/kaputtnik/Quellcode/widelands-repo/build19/src/network/netclient.h:25:0,
                 from /home/kaputtnik/Quellcode/widelands-repo/build19/src/network/netclient.cc:20:
/home/kaputtnik/Quellcode/widelands-repo/build19/src/logic/game_settings.h: In Elementfunktion »void NetClient::receive_one_user(uint32_t, StreamRead&)«:
/home/kaputtnik/Quellcode/widelands-repo/build19/src/logic/game_settings.h:52:8: Fehler: »newuser.UserSettings::position« könnte in dieser Funktion uninitialisiert verwendet werden [-Werror=maybe-uninitialized]
 struct UserSettings {
        ^~~~~~~~~~~~
cc1plus: Einige Warnungen werden als Fehler behandelt
make[2]: *** [src/network/CMakeFiles/network.dir/build.make:111: src/network/CMakeFiles/network.dir/netclient.cc.o] Fehler 1
make[1]: *** [CMakeFiles/Makefile2:26197: src/network/CMakeFiles/network.dir/all] Fehler 2
make: *** [Makefile:141: all] Fehler 2

Not sure if this has to be reported for the metaserver on github. For me it means that i can't check build19 related issues anymore.

[Hans Joachim Desserud (hjd)]

Thanks for reporting.

I haven't checked with my Arch vm yet. However, I note that the Widelands package in Arch was rebuilt January 6th (https://www.archlinux.org/packages/?q=widelands), due to boost 1.66.0 (https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/widelands&id=219342d1410582023abc29662926f325eeb3d083)

So it looks like that has built without any issues or additional patches needed.

Went looking a bit since the error message looked familiar, and I believe it might be the same as in bug 1695879. Are you trying to build the original build19? If you look at https://code.launchpad.net/~widelands-dev/widelands/b19_gcc7 a couple of commits were added post-release to fix some translation errors and more importantly build failures which occured with gcc7. So it might be the changes from r8149 in that branch which are missing. Could you check if this is the case?

[kaputtnik (franku)]

Ah, thanks for the hint about new code changes regarding build 19. I wasn't aware of it.

After bzr pull and recompiling works :-)

Sorry for the noise.

[Hans Joachim Desserud (hjd)]

Ok, great to hear you got things working. Marking this as a duplicate of bug bug 1695879 then.