Switch off ASAN in ubuntu packaging

[GunChleoc]

Our daily packages are failing, because the tests are failing with ASAN. We need to switch off ASAN in widelands-daily.

The CMake switch is -DOPTION_ASAN=OFF

[kaputtnik (franku)]

At least one user has also problems when compiling: https://wl.widelands.org/forum/topic/4153/

It is strange that tinker has problems whereas i have not, although we use the same linux distribution. I do not understand much of this, so i have some questions:

- Where do i see which compiler is used for compiling widelands? I have gcc and clang installed (clang because of a depency to qtreator). The compile output just states:

> -- The C compiler identification is GNU 7.2.0
> -- The CXX compiler identification is GNU 7.2.0
> -- Check for working C compiler: /usr/bin/cc

- Do ASAN work with gcc as well as with clang?

[GunChleoc (gunchleoc)]

The compile output you posted is exactly the information you're looking for - GNU means GCC (= GNU Compiler Collection)

ASan works with GCC.

[Hans Joachim Desserud (hjd)]

Pushed a branch which adds it alongside the other CMake options in the debian/rules file.

I haven't followed the details around the ASAN introduction. Is this change temporary until we shake out the bugs discovered or will ASAN target development and debug builds where we can stop once an error occurs?

[GunChleoc (gunchleoc)]

The default in compile.sh is to have ASan on for debug builds and off for release builds. I have added an option to switch it off though, because it is producing lots of crashes right now. ASan will be a permanent build feature, because it will also stop us from making some mistakes in the future.

In the CMakeLists.txt file, the default is ON.

Basically, default build = debug mode & everything switched on.

I would still like separate control over the LeakSanitizer, but everything the internet tells me to do doesn't work.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1