AI Data needs to write remaining buildings as strings

[GunChleoc]

GamePlayerAiPersistentPacket writes the list of remaining_basic_buildings as IDs. This is unstable, since the identity if the IDs is not guaranteed during saveloading.

Save player.tribe().get_building_descr(index)->name() as a string instead.

cf. https://bugs.launchpad.net/widelands/+bug/1705950/comments/39

[hessenfarmer (stephan-lutz)]

did some testing here are my results:

It was definitly one of the changes in r8493 as I tested the provided test game in 8492 and it is loading fine. So I doubt that the issue is about writing the data.
Bug is reproducible in the empire 4 scenario. I did a quick test on a normal map (Einschlag) and there it was not reproducible (saved 3 times, all savegames were loadable).
It is not related to Vesta (aka Player 3) as the game will crash while loading player 2 if player 2 has not achieved basic economy.
I am not sure if this is related to my changes in tribes init.lua and empire.lua will try to port the mission to the new custom load mechanism and try again.

[TiborB (tiborb95)]

oh, I am bit surprised....

[GunChleoc (gunchleoc)]

Well, I overlooked it too when I worked on the code.

[hessenfarmer (stephan-lutz)]

did another test without using my datadir (using the normal datadir of the installation. I tried it with the empire mission 3 --> same behaviour there.
so it seems this is scenario related. It seems to be not related to my empire 4 branch then and not related to normal games

[hessenfarmer (stephan-lutz)]

In my opinion this bug should be rated as important as it prevents saving a scenario game.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1