Second builder on colonizing port constructionsite

[Leighton Man]

Backtrace info:
Thread 1 "widelands" received signal SIGSEGV, Segmentation fault.
Widelands::PartiallyFinishedBuilding::request_builder_callback (game=..., rq=..., w=0x29e6f30, target=...) at /home/leighton/
builds/widelands-bzr/src/widelands-bzr/src/logic/map_objects/tribes/partially_finished_building.cc:191
191 delete &rq;
#0 Widelands::PartiallyFinishedBuilding::request_builder_callback (game=..., rq=..., w=0x29e6f30, target=...) at /home/leigh
ton/builds/widelands-bzr/src/widelands-bzr/src/logic/map_objects/tribes/partially_finished_building.cc:191
#1 0x006d79c7 in Widelands::Ship::ship_update_idle (this=<optimized out>, game=..., state=...) at /home/leighton/builds/wide
lands-bzr/src/widelands-bzr/src/logic/map_objects/tribes/ship.cc:651
#2 0x006d8879 in Widelands::Ship::ship_update (this=0x27d5420, game=..., state=...) at /home/leighton/builds/widelands-bzr/s
rc/widelands-bzr/src/logic/map_objects/tribes/ship.cc:286
#3 0x00694874 in Widelands::Bob::do_act (this=0x27d5420, game=...) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/
src/logic/map_objects/bob.cc:194
#4 0x006a7d75 in Widelands::CmdAct::execute (this=0x2da0230, game=...) at /home/leighton/builds/widelands-bzr/src/widelands-
bzr/src/logic/map_objects/map_object.cc:100
#5 0x00735be5 in Widelands::CmdQueue::run_queue (this=0xbfffcdc0, interval=66, game_time_var=@0xbfffcaf8: 15440342) at /home
/leighton/builds/widelands-bzr/src/widelands-bzr/src/logic/cmd_queue.cc:123
#6 0x0066247c in Widelands::Game::think (this=0xbfffcaf4) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/logic
/game.cc:548
#7 0x0081c3ea in InteractiveBase::think (this=0x14e5960) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/wui/in
teractive_base.cc:388
#8 0x0082a552 in InteractivePlayer::think (this=0x14e5960) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/wui/
interactive_player.cc:270
#9 0x007b5f65 in UI::Panel::do_think (this=0x14e5960) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/ui_basic/
panel.cc:456
#10 0x007b6f75 in UI::Panel::do_run (this=<optimized out>) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/ui_ba
sic/panel.cc:181
#11 0x006676d3 in UI::Panel::run<UI::Panel::Returncodes> (this=<optimized out>) at /home/leighton/builds/widelands-bzr/src/wi
delands-bzr/src/ui_basic/panel.h:99
#12 Widelands::Game::run (this=<optimized out>, loader_ui=<optimized out>, start_game_type=Widelands::Game::Loaded, script_to
_run=..., replay=false, prefix_for_replays=...) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/logic/game.cc:51
8
#13 0x00669ecc in Widelands::Game::run_load_game (this=<optimized out>, filename=..., script_to_run=...) at /home/leighton/bu
ilds/widelands-bzr/src/widelands-bzr/src/logic/game.cc:374
#14 0x005b3c4f in WLApplication::load_game (this=0xbbe4f0) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/wlapp
lication.cc:1293
#15 0x005b538a in WLApplication::mainmenu_singleplayer (this=<optimized out>) at /home/leighton/builds/widelands-bzr/src/wide
lands-bzr/src/wlapplication.cc:1124
#16 0x005b582e in WLApplication::mainmenu (this=<optimized out>) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src
/wlapplication.cc:1025
#17 0x005b5eab in WLApplication::run (this=<optimized out>) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/wlap
plication.cc:446
#18 0x0057412b in main (argc=1, argv=0xbffffa04) at /home/leighton/builds/widelands-bzr/src/widelands-bzr/src/main.cc:49

[TiborB (tiborb95)]

Based from the backtrace the scenario could be: Ship was carrying a builder but target constructionsite was destroyed (teritory conquered?) so ship went idle and worker attempted to remove request for himself...
Does it make sense, Lenghton?

[TiborB (tiborb95)]

Oh no. It was colonizing ship building a port. Perhaps landing second builder?

[Leighton Man (leightonman)]

There is certainly a colonising ship constructing a port but the ship is still offshore and when the saved game is loaded, it is only 18% complete. The game crashes as soon as construction reaches 20%.

Does that help?

[TiborB (tiborb95)]

If we go after "two builders theory", can you confirm that there are two builders on constructionsite+ship?
In this case, unloading of second one could cause the problem...

[Leighton Man (leightonman)]

How do I find that information? If I click on the ship, a window appears but shows no wares; if i click on the port under construction, a window appears showing wares but no workers.
As an experiment, I sank the ship whilst construction was at 19%. Construction continued to 20% and the game crashed

[TiborB (tiborb95)]

Is it yours ship or enemy's? But never mind. I or somebody else will investigate it. Thanks for reporting...

BTW can there be second ship elsewhere just going to unload wares/workers?

[Leighton Man (leightonman)]

I have only two ships and a third under construction (18% complete). The ship next to the port under construction is mine and was the first to be completed. The second ship is still next to the shipyard and has not moved. So, no other ships unloading and the one next to the construction site unloaded a while ago. Good luck with the investigation.

[TiborB (tiborb95)]

It could be a ship of other (AI) players. But we will see...

[TiborB (tiborb95)]

Well, the particular port (constructionsite) is at 25x125, indeed the ship unloads builder when the other builder is there and request for builder is already closed (nullptr) it MAY crash.
I cant see the layout (it is enemy), but perhaps the constructionsite got connected via road and builder come there before the builder from ship was unloaded.

[TiborB (tiborb95)]

I prepared a fix (bzr push lp:~widelands-dev/widelands/bug-1727673), not tested intensively...

[GunChleoc (gunchleoc)]

Fixed in build20-rc1