widelands

ai_help_structs: Assertion `all_stats.count(pl2) > 0' failed.

Bug #1724073 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build20-rc1

Bug Description

While training the next tournament round i ran into this crash:

widelands: ../src/ai/ai_help_structs.cc:1308: bool Widelands::PlayersStrengths::players_in_same_team(Widelands::PlayerNumber, Widelands::PlayerNumber): Assertion `all_stats.count(pl2) > 0' failed.

Map Desert Tournament restricted to 2 Players (blue vs green), win condition: collectors.

Backtrace is attached

Savegame will follow.

See original description
Tags: ai crash

Related branches

lp:~widelands-dev/widelands/ai_small_requests
GunChleoc: Approve
kaputtnik (community): Approve (testing)
Diff: 296 lines (+73/-31)
4 files modified
src/ai/ai_help_structs.cc (+37/-18)
src/ai/ai_help_structs.h (+5/-3)
src/ai/defaultai.cc (+28/-10)
src/ai/defaultai_warfare.cc (+3/-0)
Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
kaputtnik (franku) wrote :

CLose after the two soldiers go into the sentry, the game crashes

kaputtnik (franku)
description: updated
Revision history for this message
TiborB (tiborb95) wrote :

Involved code was not changed for some time so it is bit weird that something like that happens, but I will investigate it of course...

Changed in widelands:
assignee: nobody → TiborB (tiborb95)
Revision history for this message
TiborB (tiborb95) wrote :

This was very interesting bug, it is good it was caught.
AI collects info for N players, where N is number of players in game. Problem was that number of players was 2, and it was collecting data for player 1 and player 2. While actual players were 1 and 4.

Changed in widelands:
importance: Undecided → Medium
status: New → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
milestone: none → build20-rc1
tags: added: ai crash
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → Fix Committed
assignee: TiborB (tiborb95) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

We have a similar crash in https://bugs.launchpad.net/widelands/+bug/1731052, starting from comment #14: https://bugs.launchpad.net/widelands/+bug/1731052/comments/14

Changed in widelands:
status: Fix Committed → Confirmed
assignee: nobody → TiborB (tiborb95)
Revision history for this message
TiborB (tiborb95) wrote :

I am not sure this is still an issue...

Revision history for this message
GunChleoc (gunchleoc) wrote :

I think so too. Let's close this and reopen should the issue surface again.

Changed in widelands:
status: Confirmed → Fix Committed
assignee: TiborB (tiborb95) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.