Please expose "allows_seafaring" in Lua interface
Bug #1718745 reported by
Steven De Herdt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Wishlist
|
Unassigned | ||
Bug Description
It would be nice if Lua scripts could detect if the map being played accommodates seafaring, for example in a minimal starting script (see https:/
Related branches
lp:~widelands-dev/widelands/bug-1718745-allows-seafaring
- GunChleoc: Needs Resubmitting
-
Diff: 1153 lines (+324/-174)39 files modifiedsrc/ai/defaultai.cc (+11/-13)
src/ai/defaultai.h (+3/-1)
src/ai/defaultai_seafaring.cc (+3/-6)
src/editor/tools/set_port_space_tool.cc (+2/-2)
src/editor/ui_menus/main_menu_save_map.cc (+1/-0)
src/logic/map.cc (+66/-50)
src/logic/map.h (+21/-9)
src/logic/map_objects/tribes/production_program.cc (+2/-2)
src/map_io/map_port_spaces_packet.cc (+2/-4)
src/map_io/s2map.cc (+24/-38)
src/map_io/s2map.h (+2/-1)
src/scripting/lua_map.cc (+54/-1)
src/scripting/lua_map.h (+3/-0)
src/wui/building_statistics_menu.cc (+2/-2)
src/wui/fieldaction.cc (+4/-2)
test/maps/expedition.wmf/scripting/init.lua (+5/-16)
test/maps/expedition.wmf/scripting/test_cancel_when_port_space_was_reached_two_ships.lua (+1/-1)
test/maps/expedition.wmf/scripting/test_ship_movement_controls.lua (+1/-1)
test/maps/expedition.wmf/scripting/test_starting_wait_a_while_cancel.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/init.lua (+1/-12)
test/maps/ship_transportation.wmf/scripting/test_many_ships.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_first_port_with_ware_in_portdock.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_first_port_with_worker_in_portdock.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_portdock_with_worker_and_ware_in_transit.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_ports_with_ware_in_transit.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_ports_with_worker_in_transit.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_second_port_with_ware_in_portdock.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_second_port_with_worker_in_portdock.lua (+1/-1)
test/maps/ship_transportation.wmf/scripting/test_rip_ship_before_picking_up_transporting_ware.lua (+2/-2)
test/maps/ship_transportation.wmf/scripting/test_rip_ship_while_transporting_ware.lua (+2/-2)
test/maps/two_ponds.wmf/elemental (+12/-0)
test/maps/two_ponds.wmf/objective (+4/-0)
test/maps/two_ponds.wmf/player_names (+10/-0)
test/maps/two_ponds.wmf/player_position (+5/-0)
test/maps/two_ponds.wmf/port_spaces (+9/-0)
test/maps/two_ponds.wmf/scripting/init.lua (+6/-0)
test/maps/two_ponds.wmf/scripting/test_seafaring.lua (+33/-0)
test/maps/two_ponds.wmf/version (+11/-0)
test/scripting/stable_save.lua (+13/-0)
| Changed in widelands: | |
| importance: | Undecided → Wishlist |
| tags: | added: lua seafaring |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
| tags: | added: lowhangingfruit |
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| status: | New → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in build20-rc1