Multilineeditbox: Advance cursor to the next line when enter is hit at the end of the string being edited

[GunChleoc]

Editor: The map option window doesn´t handle the Enter key well while editing the map´s Description. The cursor seems to remain in the old space (not moving down a line) but when typing another letter it is entered in the new line, where the cursor now appears. Internally, everything is as expected; the cursor position just isn´t drawn properly.

[Jukka Pakarinen (flegu)]

When accessing to the map option, Valgrind detects multiple "Conditional jump or move depends on uninitialised value(s)" cases. I think if there is uninitialized values they may cause unexpected actiions.

[Jukka Pakarinen (flegu)]

After the access to the window, I set cursor to the Description and pressed enter 10 times and then one space. Scrollbar popped on and Valgrind detects quite a lot "Conditional jump or move depends on uninitialised value(s)" cases. The below I added just a few of those.

==8357== Conditional jump or move depends on uninitialised value(s)
==8357== at 0xAE9153: RenderTarget::clip(Rect<float>&) const (rendertarget.cc:373)
==8357== by 0xAE8AD5: RenderTarget::tile(Rect<int> const&, Image const*, Vector2<int> const&, BlendMode) (rendertarget.cc:235)
==8357== by 0xD1A982: UI::Scrollbar::draw_button(RenderTarget&, UI::Scrollbar::Area, Rect<int> const&) (scrollbar.cc:236)
==8357== by 0xD1C3AA: UI::Scrollbar::draw(RenderTarget&) (scrollbar.cc:351)
==8357== by 0xD15365: UI::Panel::do_draw_inner(RenderTarget&) (panel.cc:725)

==8357== Conditional jump or move depends on uninitialised value(s)
==8357== at 0xAE8BCB: RenderTarget::tile(Rect<int> const&, Image const*, Vector2<int> const&, BlendMode) (rendertarget.cc:264)
==8357== by 0xD1A982: UI::Scrollbar::draw_button(RenderTarget&, UI::Scrollbar::Area, Rect<int> const&) (scrollbar.cc:236)
==8357== by 0xD1C3AA: UI::Scrollbar::draw(RenderTarget&) (scrollbar.cc:351)
==8357== by 0xD15365: UI::Panel::do_draw_inner(RenderTarget&) (panel.cc:725)

==8357== Conditional jump or move depends on uninitialised value(s)
==8357== at 0xAE91D5: RenderTarget::clip(Rect<float>&) const (rendertarget.cc:380)
==8357== by 0xAE8427: RenderTarget::brighten_rect(Rect<int> const&, int) (rendertarget.cc:136)
==8357== by 0xD1AD63: UI::Scrollbar::draw_button(RenderTarget&, UI::Scrollbar::Area, Rect<int> const&) (scrollbar.cc:262)
==8357== by 0xD1C3AA: UI::Scrollbar::draw(RenderTarget&) (scrollbar.cc:351)
==8357== by 0xD15365: UI::Panel::do_draw_inner(RenderTarget&) (panel.cc:725)

==8357== Conditional jump or move depends on uninitialised value(s)
==8357== at 0xAE9296: RenderTarget::clip(Rect<float>&) const (rendertarget.cc:389)
==8357== by 0xAE8427: RenderTarget::brighten_rect(Rect<int> const&, int) (rendertarget.cc:136)
==8357== by 0xD1AE2C: UI::Scrollbar::draw_button(RenderTarget&, UI::Scrollbar::Area, Rect<int> const&) (scrollbar.cc:264)
==8357== by 0xD1C3AA: UI::Scrollbar::draw(RenderTarget&) (scrollbar.cc:351)
==8357== by 0xD15365: UI::Panel::do_draw_inner(RenderTarget&) (panel.cc:725)

Then I moved cursor back to the first line and pressed enter few times. Instead of seeing new lines the cursor moved forward.

[Jukka Pakarinen (flegu)]

With the following change all those "Conditional jump or move depends on uninitialised value(s)" mesages are gone.

=== modified file 'src/ui_basic/multilineeditbox.cc'
--- src/ui_basic/multilineeditbox.cc 2017-09-20 21:27:25 +0000
+++ src/ui_basic/multilineeditbox.cc 2017-12-03 16:32:02 +0000
@@ -105,6 +105,7 @@
    : scrollbar(&o, o.get_w() - Scrollbar::kSize, 0, Scrollbar::kSize, o.get_h(), button_background),
      background(init_background),
      cursor_pos(0),
+ lineheight(1),
      maxbytes(std::min(g_gr->max_texture_size() / UI_FONT_SIZE_SMALL, 0xffff)),
      ww_valid(false),
      owner(o) {

The original problem is still there. I'm not sure is the initial value ok?

[Jukka Pakarinen (flegu)]

I found where the problem is and made a branch which fixes it.

[GunChleoc (gunchleoc)]

Great, can you make a merge request?

[GunChleoc (gunchleoc)]

Fixed in build20-rc1