gcc7: trunk fails to compile a release build

Bug #1695879 reported by kaputtnik
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands (Debian)
Fix Released
Unknown
widelands (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Using the compile.sh script trunk fails to create a release build using gcc7 with the error shown in the attachment.

Related branches

Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
kaputtnik (franku) wrote :

Sorry, the error is missing in the previous attached file... here it is:

In file included from /home/kaputtnik/widelands-repo/trunk/src/network/gameclient.h:25:0,
                 from /home/kaputtnik/widelands-repo/trunk/src/network/gameclient.cc:20:
/home/kaputtnik/widelands-repo/trunk/src/logic/game_settings.h: In member function 'void GameClient::receive_one_user(uint32_t, StreamRead&)':
/home/kaputtnik/widelands-repo/trunk/src/logic/game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct UserSettings {
        ^~~~~~~~~~~~
cc1plus: some warnings being treated as errors
make[2]: *** [src/network/CMakeFiles/network.dir/build.make:111: src/network/CMakeFiles/network.dir/gameclient.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:27411: src/network/CMakeFiles/network.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Indeed, there's a merge proposal for this issue. It has built successfully, but I believe GunChleoc is cleaning up some remaining issues.

It is good to have a bug report on this, so thanks for reporting. I assume it is only a matter of time before maintainers will try (or need) to rebuild Widelands with gcc7 and hopefully this branch or patch will save them duplicating too much of the work.

Changed in widelands:
importance: Undecided → Medium
milestone: none → build20-rc1
status: New → In Progress
tags: added: ftbfs gcc
Revision history for this message
GunChleoc (gunchleoc) wrote :

I think we should add the patch to the Build19 branch too when it's done - it will make life easier for packagers.

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Debian (and Ubuntu) has begun rebuilding packages as part of making GCC7 the default compiler, so adding bug watches and updating to make this easier to find.

There's an updated branch for build19 https://code.launchpad.net/~widelands-dev/widelands/b19 with patches for building with GCC7 (specifically http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149)

tags: added: patch
tags: added: artful
Changed in widelands (Debian):
status: Unknown → New
Changed in widelands (Debian):
status: New → Fix Released
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Fixed in version 1:19+repack-4 which is available on Ubuntu Artful.

Changed in widelands (Ubuntu):
status: New → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.