widelands

Multiplayer clients crashes if no map has been selected

Bug #1691335 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned
widelands build20-rc1

Bug Description

To reproduce, open a new multiplayer game and cancel the map selection, so that you end up with no map.

Then connect with a client -> the client crashes with a segfault.

In bzr8352, the client will show an exception and bump back to the main menu.

@Notabilis: can you take on the exception handling in the network interface? I will look into the cause for the exception.

Related branches

lp:~widelands-dev/widelands/bug-1691335-network-empty-map-wincondition
Notabilis: Approve
Diff: 100 lines (+24/-19)
4 files modified
src/scripting/run_script.cc (+5/-0)
src/ui_fsmenu/launch_game.cc (+11/-17)
src/ui_fsmenu/launch_game.h (+2/-2)
src/ui_fsmenu/launch_mpg.cc (+6/-0)
Revision history for this message
GunChleoc (gunchleoc) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

This is what the exception looks like in bzr8352.

Revision history for this message
Notabilis (notabilis27) wrote :

Ha, not guilty! Okay, took me some time, but I figured it out.
The nice window before the merge appears because you are using a *release* build for that version. In release builds we have a catch-all clause in wlapplication.cc:1040 which transforms the exception to a nice window. In debug builds we are not catching it so the developer can deal with it (as happened in the newer version).

Revision history for this message
GunChleoc (gunchleoc) wrote :

Duh, that's what happens when I don't remember my own code. Thanks for checking!

Changed in widelands:
status: New → Fix Committed
assignee: Notabilis (notabilis27) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.