master miners at home bug revival
Bug #1664145 reported by
toptopple
This bug report is a duplicate of:
Bug #1545647: Upgraded workers not requested properly in productionsites.
Edit
Remove
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Committed
|
High
|
Unassigned | ||
Bug Description
Bug #535813 (Master miners stay at home) exactly describes the problem which is active for me in revision 8279. Look at post #10 which describes the situation in detail. The bug was marked fixed but somehow has been revived. Also I remember miner assignments worked for good not long ago. The code must make sure that Master Miners also inherit the lower miners' properties, but ranking lower so that lower miners are preferred for lower posts.
Related branches
lp:~widelands-dev/widelands/bug-1664145-miners
- TiborB: Approve
-
Diff: 87 lines (+37/-8)3 files modifiedsrc/logic/map_objects/tribes/warehouse.cc (+7/-7)
src/logic/map_objects/tribes/warehouse.h (+1/-1)
test/maps/plain.wmf/scripting/test_upgraded_workers.lua (+29/-0)
| tags: | added: economy regression |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
Revision history for this message
| toptopple (7010622-q-deactivatedaccount) wrote | #1 |
Revision history for this message
| toptopple (7010622-q-deactivatedaccount) wrote | #2 |
| Changed in widelands: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
To post a comment you must log in.
Any hint on where the related code is positioned?
Should we mark Importance "High" here? The bug is annoying in any game playing Barbarians, unless perhaps it is related to special circumstance. Confirmations?