widelands

Ships can have multiple windows

Bug #1663490 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build20-rc1

Bug Description

Every time you click on a ship, a new window is opened, even if there is one open already. If multiple windows are open and the ship is sunk, Widelands will segfault.

Tags: crash ui

Related branches

lp:~widelands-dev/widelands/bug-1663490-ship-windows
GunChleoc: Approve
Notabilis: Needs Resubmitting
Diff: 79 lines (+16/-6)
4 files modified
src/ui_basic/unique_window.cc (+4/-0)
src/wui/interactive_gamebase.cc (+7/-1)
src/wui/shipwindow.cc (+2/-2)
src/wui/shipwindow.h (+3/-3)
Revision history for this message
Notabilis (notabilis27) wrote :

I can reproduce the part with the multiple windows and I agree that only one should be opened. But I can't reproduce the crash in trunk r8279. Any hints or save games how to do so?

Revision history for this message
GunChleoc (gunchleoc) wrote :

I simply opened multiple windows for the same ship and then used one of them to sink the ship.

I don't think that we will need to investigate the crash though. It is probably caused by one of the remaining windows trying to access the ship which is no longer there.

GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → Notabilis (notabilis27)
status: New → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: Notabilis (notabilis27) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.