flags of buildhelp overlay does not fit with roads

[kaputtnik]

As one can see on the attached screenshot, there is a shift to bottom of the flags foot regarding to the roads.

[GunChleoc (gunchleoc)]

Does the same shift happen with busy roads? If yes, change the flag animation's hotspot, if not, edit the normal road texture.

[kaputtnik (franku)]

The shift does also happen with busy roads. But fixing this is behind my knowledge because the hotspot of the overlay is calculated in C++. I looked into it, and it seems that the culprit is this for loop:

http://bazaar.launchpad.net/~widelands-dev/widelands/hotspot_fixes/view/head:/src/wui/field_overlay_manager.cc#L42

It iterates also over 'set_flag' and sets the hotspot to it, whereas the image "set_flag" needs different calculation of the hotspot. See the lines above the for loop. Setting a specific hotspot for set_flag has no effect then. From my understanding the for loop should omit the first entry in 'buildhelp_info' or/and 'filename'.

The linked branch has fixes for bug 1647274 (hotspot of atlantean tower when enhanced to high tower).

Feel free to make the appropriate changes to the linked branch.

[kaputtnik (franku)]

OK, this was introduced with r8205 (fix compiler warnings):

http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/8205#src/wui/field_overlay_manager.cc

I changed the code to the state before the change and all is fine now. Also no compiler warnings.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1