Map Editor Parent Directory Error

[Tino]

Steps to reproduce:
1.) Start Map Editor
2.) Open Save Dialog => You are in ~/.widelands/maps/My_Maps => Only Maps and (if existing) subdirs are shown
3.) Go into a Subdir or use create subdir to create a new subdir => <parent> and if existing maps are shown
4.) Double click <parent> to go back into My_Maps

=> Now there is still a <parent> entry shown and if clicked this leads to an unexpected_error message about string manipulation.

This bug is present in branch https://code.launchpad.net/~widelands-dev/widelands/bug-1588063

[GunChleoc (gunchleoc)]

I can't reproduce this.

[GunChleoc (gunchleoc)]

I can reproduce this on Windows. It also get a crash if I have "<" in the directory name when I create it. I also tested input in Arabic script, which does not crash.

On Linux, I got a crash when I called it ".." - should be fixed already in the attached branch.

[GunChleoc (gunchleoc)]

List of illegal characters for Windows:

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

Linux:

http://www.linfo.org/file_name.html

Mac:

https://support.apple.com/en-us/HT202808

We can't just regex for [\w\d]*, because this would disallow filenames in Arabic, Russian, Chinese etc.

[GunChleoc (gunchleoc)]

The problem is - who would have thought - the file separator:

Current dir is: maps\My_Maps
Base dir is: maps\My_Maps

NOCOM double-clicked! (entering subdir)
Current dir is: maps/My_Maps/gun ain
Base dir is: maps\My_Maps
Dirs not equal - add parent

NOCOM double-clicked! (back to original dir)
Current dir is: maps/My_Maps
Base dir is: maps\My_Maps
Dirs not equal - add parent

NOCOM double-clicked! (fake parent dir)
<crash>

So, after fixing this, we should also test nested subdirectories.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.