Crash when pressing tab key in help menu
Bug #1600633 reported by
Notabilis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Notabilis | ||
Bug Description
When pressing the tab-key in a list of the help menu the game segfaults.
Reproduce:
- Start a game
- Open the help menu
- Click on an entry in the left list
- Press Tab-key
- Enjoy your desktop wallpaper
The problem is an memory access behind the end of the panel list. When the currently focused panel is the last panel in the list, next_ is 0x0 resulting in a crash when accessed.
The linked branch fixes this crash by switching to the first element in the list (similar to what is done later on when the list is traversed).
Edit: Happens in trunk revision bzr8028
Related branches
lp:~notabilis27/widelands/bug-tab-crash
- SirVer: Approve
-
Diff: 28 lines (+6/-1)2 files modifieddata/txts/developers.json (+2/-1)
src/ui_basic/panel.cc (+4/-0)
| description: | updated |
| description: | updated |
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| assignee: | nobody → Notabilis (notabilis27) |
| Changed in widelands: | |
| status: | Confirmed → Fix Committed |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
To post a comment you must log in.
Fixed in build19-rc1.