inconsistent production values of mines
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The barbarian's mines have inconsistent values for production specified in the lua-files. I'll assume one unit of the respective required food consumed in the following.
In mines you get 2 coal but only one iron or gold ore. This would make sense if the difference would be kept with enhanced mines. But in deep mines you get 4 coal or for 4 gold ore but two iron ore. And in deeper mines you get 5 coal, 4 gold or 5 iron ore.
In addition, the production times ans sequence of deeper mines vary pretty widely:
Coal mines produce 5 ores in 72 seconds and two steps
Iron mines produce 5 ores in 88 seconds and three steps
Gold mines produce 4 ores in 74 seconds and two steps
I don't even have an idea how it is intended to be ...
Related branches
- GunChleoc: Approve
- Toni Förster: Approve
- hessenfarmer: Needs Resubmitting
- Benedikt Straub: Approve (review)
-
Diff: 2981 lines (+958/-490)70 files modifieddata/campaigns/emp04.wmf/scripting/tribes/farm2.lua (+1/-1)
data/tribes/buildings/productionsites/atlanteans/armorsmithy/init.lua (+6/-6)
data/tribes/buildings/productionsites/atlanteans/coalmine/init.lua (+34/-10)
data/tribes/buildings/productionsites/atlanteans/crystalmine/init.lua (+70/-34)
data/tribes/buildings/productionsites/atlanteans/goldmine/init.lua (+22/-10)
data/tribes/buildings/productionsites/atlanteans/ironmine/init.lua (+24/-8)
data/tribes/buildings/productionsites/atlanteans/smelting_works/init.lua (+2/-4)
data/tribes/buildings/productionsites/atlanteans/smokery/init.lua (+2/-6)
data/tribes/buildings/productionsites/atlanteans/toolsmithy/init.lua (+19/-31)
data/tribes/buildings/productionsites/atlanteans/weaponsmithy/init.lua (+15/-15)
data/tribes/buildings/productionsites/atlanteans/weaving_mill/init.lua (+8/-11)
data/tribes/buildings/productionsites/barbarians/ax_workshop/init.lua (+9/-9)
data/tribes/buildings/productionsites/barbarians/big_inn/init.lua (+7/-6)
data/tribes/buildings/productionsites/barbarians/coalmine/init.lua (+20/-3)
data/tribes/buildings/productionsites/barbarians/coalmine_deep/init.lua (+23/-7)
data/tribes/buildings/productionsites/barbarians/coalmine_deeper/init.lua (+24/-7)
data/tribes/buildings/productionsites/barbarians/goldmine/init.lua (+2/-1)
data/tribes/buildings/productionsites/barbarians/goldmine_deep/init.lua (+23/-7)
data/tribes/buildings/productionsites/barbarians/goldmine_deeper/init.lua (+23/-7)
data/tribes/buildings/productionsites/barbarians/granitemine/init.lua (+21/-4)
data/tribes/buildings/productionsites/barbarians/helmsmithy/init.lua (+9/-9)
data/tribes/buildings/productionsites/barbarians/inn/init.lua (+1/-2)
data/tribes/buildings/productionsites/barbarians/ironmine/init.lua (+2/-1)
data/tribes/buildings/productionsites/barbarians/ironmine_deep/init.lua (+21/-5)
data/tribes/buildings/productionsites/barbarians/ironmine_deeper/init.lua (+22/-8)
data/tribes/buildings/productionsites/barbarians/smelting_works/init.lua (+2/-4)
data/tribes/buildings/productionsites/barbarians/tavern/init.lua (+4/-2)
data/tribes/buildings/productionsites/barbarians/warmill/init.lua (+18/-18)
data/tribes/buildings/productionsites/empire/armorsmithy/init.lua (+13/-12)
data/tribes/buildings/productionsites/empire/coalmine/init.lua (+22/-7)
data/tribes/buildings/productionsites/empire/coalmine_deep/init.lua (+24/-7)
data/tribes/buildings/productionsites/empire/goldmine/init.lua (+19/-5)
data/tribes/buildings/productionsites/empire/goldmine_deep/init.lua (+20/-5)
data/tribes/buildings/productionsites/empire/inn/init.lua (+5/-6)
data/tribes/buildings/productionsites/empire/ironmine/init.lua (+20/-5)
data/tribes/buildings/productionsites/empire/ironmine_deep/init.lua (+23/-7)
data/tribes/buildings/productionsites/empire/marblemine/init.lua (+48/-18)
data/tribes/buildings/productionsites/empire/marblemine_deep/init.lua (+31/-7)
data/tribes/buildings/productionsites/empire/smelting_works/init.lua (+2/-4)
data/tribes/buildings/productionsites/empire/tavern/init.lua (+3/-2)
data/tribes/buildings/productionsites/empire/weaponsmithy/init.lua (+15/-15)
data/tribes/buildings/productionsites/frisians/armor_smithy_large/init.lua (+9/-9)
data/tribes/buildings/productionsites/frisians/armor_smithy_small/init.lua (+10/-9)
data/tribes/buildings/productionsites/frisians/blacksmithy/init.lua (+12/-12)
data/tribes/buildings/productionsites/frisians/coalmine/init.lua (+20/-3)
data/tribes/buildings/productionsites/frisians/coalmine_deep/init.lua (+26/-13)
data/tribes/buildings/productionsites/frisians/drinking_hall/init.lua (+6/-3)
data/tribes/buildings/productionsites/frisians/furnace/init.lua (+2/-4)
data/tribes/buildings/productionsites/frisians/goldmine/init.lua (+2/-1)
data/tribes/buildings/productionsites/frisians/goldmine_deep/init.lua (+24/-7)
data/tribes/buildings/productionsites/frisians/honey_bread_bakery/init.lua (+3/-3)
data/tribes/buildings/productionsites/frisians/ironmine/init.lua (+2/-1)
data/tribes/buildings/productionsites/frisians/ironmine_deep/init.lua (+26/-7)
data/tribes/buildings/productionsites/frisians/mead_brewery/init.lua (+3/-3)
data/tribes/buildings/productionsites/frisians/recycling_center/init.lua (+2/-2)
data/tribes/buildings/productionsites/frisians/rockmine/init.lua (+19/-5)
data/tribes/buildings/productionsites/frisians/rockmine_deep/init.lua (+26/-10)
data/tribes/buildings/productionsites/frisians/sewing_room/init.lua (+2/-1)
data/tribes/buildings/productionsites/frisians/smokery/init.lua (+2/-2)
data/tribes/buildings/productionsites/frisians/tailors_shop/init.lua (+6/-4)
data/tribes/buildings/productionsites/frisians/tavern/init.lua (+8/-4)
data/tribes/buildings/trainingsites/atlanteans/dungeon/init.lua (+1/-0)
data/tribes/buildings/trainingsites/barbarians/battlearena/init.lua (+1/-0)
data/tribes/buildings/trainingsites/empire/arena/init.lua (+1/-1)
data/tribes/buildings/trainingsites/empire/colosseum/init.lua (+1/-0)
data/tribes/buildings/trainingsites/frisians/training_arena/init.lua (+1/-0)
data/tribes/scripting/help/ware_help.lua (+55/-44)
data/txts/developers.json (+1/-0)
src/logic/map_objects/tribes/production_program.cc (+4/-3)
src/logic/map_objects/tribes/worker.cc (+4/-3)
Changed in widelands: | |
status: | New → Fix Released |
Okay, since it was apparently unclear what I was aiming for, I'll try to explain again.
I'll make three assumptions about how mines work that seem naturally logical: crystals can be somewhere in between.
1. Different minerals take different times to mine (not necessarily but it's easily comprehensible). Gold takes longer than iron which takes longer than coal. Stone/marble/
2. Enhanced mines work faster but require more resources per output unit than the previous stage.
3. The differences of basic mines persist with enhanced versions (pretty basic logic).
Atlanteans and Empire follow these rules almost perfectly. Atlanteans for example can mine coal every 15 seconds, iron every 21 seconds and gold every 35 seconds. That looks really convincing.
Barbarians on the other hand ...
With simple mines they get iron as fast as gold. One could argue that all of them should need the same time for a cycle and since iron gives only one unit per cycle gold can't get any lower. But then again, the mines on other levels don't have equal times either and I don't see a reason why they would absolutely need to.
But it's getting even worse with deep mines. Here they gain gold twice as fast as iron and on equal speed with coal! Btw, it's the same with the food requirement.
With deeper mines the order of the speeds is fine but the differences are pretty small: 14.4 seconds for coal, 17.6 for iron and 18.5 for gold.
On average this means, that Barbarians can mine gold much faster than any other tribe and faster than they mine iron. While I understand that one tribe might be better (and thus faster) miners than another it doesn't seem convincing why they should be able to mine one specific ore faster or slower, let alone why one upgrade would be faster or slower over the other mines of the same stage compared to the mines of another stage.
I didn't include stone here because I don't think that the same rules apply. Empire and Atlanteans are looking for specific, more rare resources here where stone is rather a byproduct so it's understandable why they could be relatively slower because they need to search more carefully, or faster, because they are more desperate/have a higher priority.