Editor crash: Assertion `1 <= p && p <= get_nrplayers()' failed.

[kaputtnik]

Steps to reproduce:

1. Start editor
2. Place one or two players
3. Create a new map

Result:
widelands: /home/kaputtnik/widelands-repo/trunk/src/logic/map.h:205: Widelands::Coords Widelands::Map::get_starting_pos(Widelands::PlayerNumber) const: Assertion `1 <= p && p <= get_nrplayers()' failed.

[kaputtnik (franku)]

This backtrace was produced through:

1. Start editor
2. Load a one player map
3. Create a new map (usually for testing i choose an unbuildable type of terrain, like water. Didn't know what kind of terrain i have chosen this time and if this is does matter at all)

But those crashes couldn't be reproduced. Earlier i loaded/saved/created new maps several times without any crash. After closing widelands and restart this crash happens.

[GunChleoc (gunchleoc)]

Did you create the backtrace with the attached branch or with trunk? I got the same point in the code before the attempted fix, so I need to ask.

[kaputtnik (franku)]

With the attached branch... just tested again and got a crash. But i have to start widelands twice to trigger the crash described in the merge proposal.

[kaputtnik (franku)]

The attachment is a log of a whole session, starting with gdb ./widelands. I have added some comments of what i have done, f.e.

## FrankU -> Place player and save map

After loading the last map the crash happens.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.