Unify terrain names; put animated terrains in subfolders
Bug #1570086 reported by
kaputtnik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
kaputtnik | ||
Bug Description
We have some terrain filenames which are spelled in german, like wiese1_00.png or strand_00.png.
I suggest to unify all filenames to english.
I would also suggest to put animated terrains in a subfolders. So f.e. all water terrains for desert are in world/terrains/
We should also rename "world/
There is no need to have this in build 19. On the other side i think this renaming wouldn't cause new bugs, so this could also be done for build 19.
If you agree with my suggestions, this would become a prerequisite for bug 951554 (impassable water), which i rescheduled for build 20.
Should this be in build19 or build20?
Related branches
lp:~widelands-dev/widelands/bug-1570086_unify_terrain_names
- GunChleoc: Approve
- kaputtnik (community): Needs Resubmitting
-
Diff: 1056 lines (+166/-128)12 files modifieddata/campaigns/atl01.wmf/scripting/water_rising.lua (+5/-5)
data/campaigns/tutorial03_seafaring.wmf/scripting/mission_thread.lua (+1/-1)
data/maps/Trident_of_Fire.wmf/scripting/map_editing.lua (+5/-5)
data/world/map_generation.lua (+16/-16)
data/world/terrains/init.lua (+61/-61)
src/map_io/map_terrain_packet.cc (+4/-6)
src/map_io/s2map.cc (+5/-6)
src/map_io/world_legacy_lookup_table.cc (+44/-3)
test/maps/lua_persistence.wmf/scripting/test_persistence.lua (+2/-2)
test/maps/lua_testsuite.wmf/scripting/cfield.lua (+8/-8)
test/maps/lua_testsuite.wmf/scripting/immovables_descriptions.lua (+1/-1)
test/maps/lua_testsuite.wmf/scripting/terrains_resources_descriptions.lua (+14/-14)
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| tags: | added: cleanups lowhangingfruit lua |
| Changed in widelands: | |
| assignee: | nobody → kaputtnik (franku) |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
To post a comment you must log in.
When we do these changes, we will have to keep the internal names of the terrains for map loading. Otherwise, we will need to add terrains to PostOneWorldLeg
I don't want to work on this for Build19, but if somebody else does, I wouldn't be opposed to having it in.