Set Origin tool crashed the editor

[GunChleoc]

To reproduce:

1. Start the editor
2. Set the origin
3. Click "Undo"

[kaputtnik (franku)]

I could confirm this with r7942. I believe the crash happens when set Origin points on a coordinate with x=0, f.e. 0, 5. Such coordinates triggers the crash reproducible.

widelands: /home/kaputtnik/Quellcode/widelands-repo/trunk/src/logic/map.cc:340: void Widelands::Map::set_origin(Widelands::Coords): Assertion `new_origin.x < width_' failed

[kaputtnik (franku)]

This is caused by map->get_width() which returns 64 for a map with width 64. The width is counted here as range 1 to 64, but map->set_origin counts range 0 to 63.

My solution would be to subtract 1 to both (width and height) in

http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/editor/tools/set_origin_tool.cc#L48

I am compiling my changes now and if i am ready i propose a branch. Somebody should may check the other usages of map->get_width() and map->get_height() to prevent some more bugs under this circumstances.

[GunChleoc (gunchleoc)]

Yes, please propose a branch. We can then use it as a base to double-check the other uses.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.