Ware statistic: Clicking the first time on an icon the graph flickers

[kaputtnik]

If one clicks on an icon in ware statistic window the graph some times overflows the drawing area for a very short time and then gets adjusted to fit.

Attached a save game where this happens: Open Ware statistic and toggle the Bread button.

[GunChleoc (gunchleoc)]

I have seen this too.

Maybe related: https://bugs.launchpad.net/widelands/+bug/1566037

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.

[kaputtnik (franku)]

This is up again. I encounter this in current trunk (r8377) for 'statistic -> ware statistic -> stock tab' when playing this savegame: https://bugs.launchpad.net/widelands/+bug/1690519/+attachment/4895312/+files/wl_autosave_00.wgf

It happens mostly when 'Beer' is clicked.

[GunChleoc (gunchleoc)]

It's not just the flicker, but also the width of the line itself.

I'm guessing that we are having an int/float problem here.

[kaputtnik (franku)]

I think the bold part of the line comes from close up and down, because the first and last part (on the left and right) looks ok for me, if you mentioned the bold part in the middle.

[GunChleoc (gunchleoc)]

You're right, it's just tight lines.

I did notice one other thing though: It doesn't flicker when the game is paused.

[kaputtnik (franku)]

I get some memory leaks with ASAN when using the save game from #4. I think this is related to WuiPlotArea::register_plot_data.

SUMMARY: AddressSanitizer: 9848 byte(s) leaked in 353 allocation(s).

[GunChleoc (gunchleoc)]

The memory leak is gone, so I'm setting this to fix committed.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1