Building access broken after citadel has been taken over

[GunChleoc]

When the citadel in the attached savegame gets taken over by the red player, the blue player suddenly gets access to all building windows.

When you move to the citadel and then save the game and load it again, the bug doesn't happen anymore.

Reported on the forum: https://wl.widelands.org/forum/topic/1946/

The attached savegame is for bzr7866

[GunChleoc (gunchleoc)]

I can't reproduce this any more with bzr7866. Anybody else?

[kaputtnik (franku)]

I have never seen this, except with the attached savegame. But it couldn't be loaded anymore....

I set this to incomplete and remove the Milestone.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[kaputtnik (franku)]

The same user has encountered this bug again: https://wl.widelands.org/forum/topic/4186/

Maybe related:
Something similar happens if you:

1. start a new game with you as first player
2. Open script console
3. p = wl.Game().players[1]
4. p.see_all = true
5. check the enemies buildings

[kaputtnik (franku)]

As far i can see both save games are played with "Endless Game (no fog)".

[kaputtnik (franku)]

I guess the player which reported this issue in the forums had encountered this because he had lost but didn't noticed it. Since he lost he got into a "spectator mode" where he can obtain the settings of all buildings. At least this is true for his last report.

I think we can close this bug as invalid for the initial bug report.

The thing mentioned in #5 is likely a different bug, if it is a bug. I think this was implemented to check enemies buildings when in scenario mode or watching the ai.