wounded attacking soldiers failing to retreat

[king of nowhere]

When an attacking soldier drops below 50% healt, it will retreat if possible, i.e. if it is not surrounded by enemies. This mechanism is malfunctioning in 7852, where soldiers keep attacking even if they are low in healt AND there are no enemies around. See attached replay

[TiborB (tiborb95)]

It seems that this union is causing a problem:

union {int32_t ivar3; uint32_t ui32var3;}

In my branch I eliminated it and created new variable of soldier object: retreat_health. One of advantages will be that the value will be visible via DBG window and also in verbose logs. So a tester will see what value is applied.

I am not able to load attached files, though...

[king of nowhere (lainluigi86)]

if you update the game to the latest version every time, of course you can't open 7852.

[TiborB (tiborb95)]

You know, nobody will create new branch from old trunk...

[GunChleoc (gunchleoc)]

That's because we broke compatibility again after this bug was posted ;)

[king of nowhere (lainluigi86)]

yeah, when i reported it, it was new. and if nobody fixed it, the bug is still there.
the replay simply showed a soldier fighting, getting wounded to below 10% of his hp, then going on attacking despite a complete lack of enemy soldiers around

[TiborB (tiborb95)]

"then going on attacking despite a complete lack of enemy soldiers around" - whom did he attack when there were no enemies?

The bottom line of bug was that there was a health threshold set properly, but shortly afterwards it was erroneously re-set to 0. This is fixed.

Also, you probably understand, threshold is tested only before engaging new opponent, during the fight (between two soldiers) threshold is not relevant.

[king of nowhere (lainluigi86)]

"whom did he attack when there were no enemies?"
he went to attack the military building. the point was that he had all the chance of retreating. Anyway, good that it is fixed

[TiborB (tiborb95)]

I hope it was fixed. I just want to emphasize, that there is DBG window that will give you more info about what is going on, can be useful when debugging their behavior.

[king of nowhere (lainluigi86)]

which one is the version where it should be fixed? because i tried the latest available windows version, the 7907, and the bug is still there

[Miroslav Remák (miroslavr256)]

This is the branch: lp:~widelands-dev/widelands/bug-1554552 . It hasn't been merged into trunk yet.

[GunChleoc (gunchleoc)]

Appveyor builds: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1554552-719

[kaputtnik (franku)]

Use this file for win 64bit: https://ci.appveyor.com/api/buildjobs/j8iabn37ek040oe5/artifacts/Widelands-_widelands_dev_widelands_bug_1554552-718-Release-x64.exe

Use this file for win 32bit: https://ci.appveyor.com/api/buildjobs/9y2eteamky7nlc1c/artifacts/Widelands-_widelands_dev_widelands_bug_1554552-718-Release-x86.exe

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.