Change player number datatype in scripting/lua_game
Bug #1545243 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
GunChleoc | ||
Bug Description
The datatype for uint32_t player_number_ in scripting/lua_game should be PlayerNumber.
PERS/UNPERS should also change datatype to uint8.
Also check the other files in scripting.
Related branches
lp:~widelands-dev/widelands/bug-1545243-plnum-lua
- Klaus Halfmann: Approve (review/compile/regression testst, playing)
- GunChleoc: Needs Resubmitting
-
Diff: 1757 lines (+257/-249)51 files modifiedsrc/ai/ai_help_structs.cc (+1/-1)
src/ai/ai_help_structs.h (+3/-3)
src/ai/defaultai.cc (+2/-2)
src/economy/economy.cc (+14/-14)
src/economy/economy.h (+11/-11)
src/economy/request.h (+3/-3)
src/economy/warehousesupply.h (+6/-6)
src/economy/wares_queue.cc (+4/-4)
src/economy/wares_queue.h (+9/-9)
src/editor/map_generator.cc (+3/-3)
src/editor/tools/action_args.h (+5/-4)
src/editor/tools/decrease_resources_tool.cc (+3/-2)
src/editor/tools/increase_resources_tool.cc (+2/-2)
src/editor/tools/info_tool.cc (+3/-2)
src/editor/tools/place_immovable_tool.cc (+1/-1)
src/editor/tools/set_resources_tool.cc (+4/-4)
src/editor/tools/set_resources_tool.h (+3/-3)
src/logic/editor_game_base.cc (+1/-1)
src/logic/editor_game_base.h (+1/-1)
src/logic/field.h (+5/-5)
src/logic/findnode.h (+6/-4)
src/logic/map.cc (+12/-12)
src/logic/map.h (+5/-5)
src/logic/map_objects/tribes/bill_of_materials.h (+1/-1)
src/logic/map_objects/tribes/militarysite.cc (+6/-6)
src/logic/map_objects/tribes/militarysite.h (+7/-7)
src/logic/map_objects/tribes/production_program.cc (+5/-5)
src/logic/map_objects/tribes/ship.h (+2/-2)
src/logic/map_objects/tribes/soldiercontrol.h (+9/-7)
src/logic/map_objects/tribes/trainingsite.cc (+4/-4)
src/logic/map_objects/tribes/trainingsite.h (+7/-7)
src/logic/map_objects/tribes/tribe_descr.cc (+4/-4)
src/logic/map_objects/tribes/tribe_descr.h (+1/-1)
src/logic/map_objects/tribes/warehouse.cc (+9/-11)
src/logic/map_objects/tribes/warehouse.h (+13/-13)
src/logic/map_objects/tribes/warelist.cc (+4/-4)
src/logic/map_objects/tribes/warelist.h (+4/-7)
src/logic/map_objects/tribes/worker.cc (+8/-8)
src/logic/map_objects/tribes/worker_descr.h (+3/-3)
src/logic/map_objects/world/resource_description.cc (+1/-1)
src/logic/map_objects/world/resource_description.h (+2/-2)
src/logic/map_objects/world/terrain_description.cc (+7/-7)
src/logic/map_objects/world/terrain_description.h (+8/-8)
src/logic/widelands.h (+2/-0)
src/map_io/map_buildingdata_packet.cc (+1/-1)
src/map_io/map_resources_packet.cc (+9/-8)
src/map_io/s2map.cc (+2/-3)
src/scripting/lua_game.h (+1/-1)
src/scripting/lua_map.cc (+24/-22)
src/wui/game_debug_ui.cc (+5/-3)
src/wui/soldierlist.cc (+1/-1)
| description: | updated |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| tags: | added: lowhangingfruit |
| Changed in widelands: | |
| status: | New → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| milestone: | build19-rc1 → none |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| milestone: | none → build19-rc1 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
To post a comment you must log in.
PERS/UNPERS is always 32 bit, so there won't be any change to savegame compatibility. Retargetting.