New map has always author of last saved map

Bug #1544913 reported by kaputtnik on 2016-02-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Medium
Unassigned

Bug Description

Start editor
Open a map from another author, f.e from the website
Save map without changing the author

In result the entry "realname" in general conf file (~/.widelands/conf) is changed to the name of the previous saved map.

See also bug 1544474 (empty fields possible)

kaputtnik (franku) on 2016-02-12
tags: added: ui
GunChleoc (gunchleoc) wrote :

I always see my own username when creating a new map. If you openend an existing map, that might change though - the name is taken from the map then.

I don't know what happens when you first open (and maybe save) an existing map, and then start a new one. The editor might remember the author of the last map then, which is not what we want.

tags: added: editor
kaputtnik (franku) wrote :

I know where the string comes from: It's suddenly in my widelands conf file (~/.widelands/conf) stored as

realname="Einstein13"

As you mentioned this change happens if you

1. load a map from another author
2. save it
3. Exit widelands

The realname in the widelands conf gets updated and contains now the string of the map author.

A solution would be:
change the realname when a new map is created
prevent the realname change when a saved map is loaded. We should also consider to prevent changing the author of a map through the ui. So a map is bound to an author and could not be easily "stolen" from another person. Changing the author of a map is than only possible through the elemental-file.

GunChleoc (gunchleoc) wrote :

The problem is that if a user forgets to add his name, the author name will be "Nobody" or something like that - we will need to think of a better UI for this. Maybe keep it empty and pop up a dialog box. On the other hand, people should also be allowed to change their name anyway.

kaputtnik (franku) on 2016-02-12
summary: - New map has always "Einstein13" as author
+ New map has always author of last saved
summary: - New map has always author of last saved
+ New map has always author of last saved map
kaputtnik (franku) on 2016-02-12
description: updated
GunChleoc (gunchleoc) on 2016-02-13
Changed in widelands:
status: New → Confirmed
importance: Undecided → Medium
kaputtnik (franku) wrote :

> we will need to think of a better UI for this.

In general i think the map options should be part of the whole "save game" process. I often forget to edit the map options and save a game without modifying the map name. When i start a new game then, it is difficult to find the right map because in the "new game" dialog only the map names are shown, and not the file names. So i have here some maps listed called "No name". Of course this is because i often make test maps for new terrains or something like that. I am aware of that this is a special use case. But i believe new map designers will overlook the map options as well. So i think the map options should be part of the whole save map process, like:

When hitting "Save Map" the "Map options" window will always appear as first window, or it would appear on top in the "Save Map" window. So nobody could overlook this options.

Related to the author it is maybe possible to prevent saving the authors name in the conf-file, when he opens a map where the author name isn't the same as the one in the conf file. F.e "kaputtnik" opens a map from author "einstein13" -> Don't change the entry in the conf file. If the conf file has no entry for the author -> don't add the authors name to the conf file unless the authors field in Map options has changed. So if "Nobody" get changed the new authors name gets written to the conf. If "Einstein13" gets changed, the new author gets written to the conf too.

Another way would be to add a checkbox: "Check if this name should be used for all maps you created" and leave this checkbox unchecked. When this is checked, add/change the entry in the conf-file.

GunChleoc (gunchleoc) on 2016-09-19
Changed in widelands:
milestone: none → build20-rc1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers