Get rid of LuaBaseImmovable::get_size

[GunChleoc]

Once we have added LuaBaseImmovable::get_fields to all subclasses, it can go.

This needs to be done before Build19, because it will break backwards compatibility.

[SirVer (sirver)]

Why do you want to get rid of it? duplicating the code in each subclass is not really better.

Also, I do not think it would break backwards compatibility, because no object of BaseImmovable could ever be instantiated (I think), it is a pure base class - or am I wrong about that?

[GunChleoc (gunchleoc)]

This is actually one of the TODOs that you created yourself:

// TODO(SirVer): size should be similar to
// https://wl.widelands.org/docs/wl/autogen_wl_map/#wl.map.BaseImmovable.size.
// In fact, as soon as all descriptions are wrapped (also for other
// immovables besides buildings) we should get rid of BaseImmovable.size.

So, I'm not sure if we want to get rid of the entire object, or just the get_size function?

[SirVer (sirver)]

My intention here was to move all the static information of an object into the descr class, not necessarily to get rid of the object. get_size will return the same value, no matter which instance of a lumberjack you call it on. So it should probably be in the descr class.

there might be other methods for which this logic applies, but I am not sure.

[GunChleoc (gunchleoc)]

I have to look at what the second function does - size is now definitely available in the description objects.

[GunChleoc (gunchleoc)]

I have played with this now - BuildingDescr and ImmovableDescr do not inherit from each other, and MapObject doesn't have size. So, all I can do is move get_size from BaseImmovable to ImmovableDescription.

LuaBaseImmovable::get_fields is a function of the actual immovable, so it will stay as it is.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.