Multiline edit box shows new text only when hitting backspace

Bug #1540782 reported by kaputtnik
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned

Bug Description

This was reported in the forum: https://wl.widelands.org/forum/topic/1923/

> When changing the map description in the editor, the visible text does not update as I type. Only after pressing backspace does it appear.

This happens also for the "Hints" field in Map options.

The offending commit is 7758, we probably need to call g_gr->refresh(); somewhere.

EditBox is fine, it's just the multiline one that is affected.

Tags: ui

Related branches

Revision history for this message
GunChleoc (gunchleoc) wrote :

I can confirm this.

Changed in widelands:
importance: Undecided → High
milestone: none → build19-rc1
summary: - Multiline text area shows new text only when hitting backspace
+ Multiline edit box shows new text only when hitting backspace
GunChleoc (gunchleoc)
description: updated
Revision history for this message
GunChleoc (gunchleoc) wrote :

I did some digging - the fix can be done in MultilineEditbox::Data::refresh_ww(). However, if I just call update() there, the whole screen flickers. So, I need help from our resident graphics expert.

Changed in widelands:
assignee: nobody → SirVer (sirver)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Found it - I was calling the wrong update function.

Changed in widelands:
assignee: SirVer (sirver) → GunChleoc (gunchleoc)
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.