empire fisher: fishing animation does not work

Bug #1529363 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

I just found one more missing animation: The empire fisher goes to to water, but do not fish. After some seconds he carrys a fish back to his fisher hut.

I found that the "idle_??" images are used both for idle and fishing. See
http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/tribes/workers/empire/fisher/init.lua
So i changed this to work again by changing "idle_??" to "fishing_??" and giving the fishing animation the fps value found in build 18 (fps = 10)

Because this is maybe not the only missing animation, i currently check all other init.lua files. Doing this i notice some inconsistency of naming the animations. F.e. the planting animation for foresters are called "crop". Where planting animations for farmers are called "planting". See

http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/tribes/workers/empire/forester/init.lua#L15
vs.
http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/tribes/workers/empire/farmer/init.lua#L9

Because i am running through all init.lua files, should i pay attention on such things and rename the animations?

Related branches

tags: added: empire gamedata
Revision history for this message
kaputtnik (franku) wrote :

GunChleoc, you have done a great work here... i didn't found any other missing animations :-)

The linked branch contains the corrections to the fishing animation and renaming some names for animations. I did a test with the three tribes and it works fine.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for the fix :)

kaputtnik (franku)
Changed in widelands:
status: New → Fix Committed
Changed in widelands:
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.