empire fisher: fishing animation does not work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I just found one more missing animation: The empire fisher goes to to water, but do not fish. After some seconds he carrys a fish back to his fisher hut.
I found that the "idle_??" images are used both for idle and fishing. See
http://
So i changed this to work again by changing "idle_??" to "fishing_??" and giving the fishing animation the fps value found in build 18 (fps = 10)
Because this is maybe not the only missing animation, i currently check all other init.lua files. Doing this i notice some inconsistency of naming the animations. F.e. the planting animation for foresters are called "crop". Where planting animations for farmers are called "planting". See
http://
vs.
http://
Because i am running through all init.lua files, should i pay attention on such things and rename the animations?
Related branches
- TiborB: Approve
-
Diff: 120 lines (+13/-12)5 files modifiedtribes/workers/atlanteans/forester/init.lua (+2/-2)
tribes/workers/barbarians/ranger/init.lua (+2/-2)
tribes/workers/empire/fisher/init.lua (+2/-1)
tribes/workers/empire/forester/init.lua (+2/-2)
tribes/workers/empire/vinefarmer/init.lua (+5/-5)
tags: | added: empire gamedata |
Changed in widelands: | |
status: | New → Fix Committed |
Changed in widelands: | |
milestone: | none → build19-rc1 |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
GunChleoc, you have done a great work here... i didn't found any other missing animations :-)
The linked branch contains the corrections to the fishing animation and renaming some names for animations. I did a test with the three tribes and it works fine.