Some buildings have lost build animations; Add check for lua tables
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
bzr 7671
During game play i saw that empire arena has no build animation anymore. Normally this building has 4 images when it will be build. See attachment. Currently only "build_00.png" is used. I checked the corresponding init.lua file and found that the "build" table has an entry "fps = 1" See http://
Removing this "fps" entry will let the other build images appear during game play. I checked some of the other files and found several "fps = 1 " entries in the build table for buildings:
barbarians_
barbarians_
barbarians_port
barbarians_
empire_port
atlanteans_port
I tested barbarians warehouse and it has also no building animation during game play. So i think the "fps = 1" property is wrong in the build table of the lua files.
May there should be a check for valid properties in each table of lua files to prevent such failures?
If some one could verify that "fps = 1" is wrong in the build table, i will make a branch containing fixed lua files.
Related branches
- GunChleoc: Approve
-
Diff: 82 lines (+0/-7)7 files modifiedtribes/buildings/trainingsites/barbarians/battlearena/init.lua (+0/-1)
tribes/buildings/trainingsites/barbarians/trainingcamp/init.lua (+0/-1)
tribes/buildings/trainingsites/empire/arena/init.lua (+0/-1)
tribes/buildings/warehouses/atlanteans/port/init.lua (+0/-1)
tribes/buildings/warehouses/barbarians/port/init.lua (+0/-1)
tribes/buildings/warehouses/barbarians/warehouse/init.lua (+0/-1)
tribes/buildings/warehouses/empire/port/init.lua (+0/-1)
summary: |
- Some buildings have no build animation; Add check for lua tables + Some buildings have lost build animations; Add check for lua tables |
Changed in widelands: | |
status: | Confirmed → Fix Committed |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
This was probably caused by the one_tribe change - I did a lot of copy/paste there.
The only checks for FPS that we have in the code is that animations with only 1 frame aren't allowed to define any FPS.
Maybe you could compare with the old conf files, e.g. by looking at the code fom Build 18.