editor does not clean up memory (?) when loading another map

Bug #1521736 reported by kaputtnik
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

If you edit a map and have some windows open, like tools menu or the info tool, and load another map, the windows remain open. Especially the info tool shows then the information from the former map, not from the actual map.

Steps to reproduce:
1. Start editor, place some terrains
2. Bring up the info tool by pressing "i" and click on some terrains or fields. Every time you click a new window will open (you could move each window)
3. Load another map or make a new empty map

Result: All formerly opened windows are still open. The windows of the info tool shows the properties of the formerly opened map.

Expected result: No window should appear when loading a map, all memory should be cleaned.

Tags: editor memory

Related branches

Revision history for this message
kaputtnik (franku) wrote :

Sorry, was in wrong project :-D

affects: widelands-media → widelands
GunChleoc (gunchleoc)
Changed in widelands:
status: New → Confirmed
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

We've had a similar issue in the past with loading savegames. That was resolved, but it wasn't clear what fixed it (bug 751836). Might want to check whether other places where loading/starting games clean up or not after all the changes since then.

tags: added: memory
Revision history for this message
kaputtnik (franku) wrote :

I've made some short tests, but i am not sure the results are right. I used [top] to show me the used memory by widelands. Is there a better way?

top says, i couldn't increase the memory usage upon a specific value. I've turned from game play to editor and back, load/create a map, load/save/create a game. So in the end widelands doesn't eat memory. I cant believe that :-O :-D

In my mind it should be enough to destroy the windows when loading/create a map.

[top]: https://en.wikipedia.org/wiki/Top_%28software%29

kaputtnik (franku)
Changed in widelands:
status: Confirmed → Fix Committed
Changed in widelands:
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.