has_workers broken (affects AI when considering upgrade)

[TiborB]

While working on AI, I found that function ProductionSite::has_workers() is badly broken, returning unreliable results.

AI is relying on it when considering if it has experienced worker for upgrade.

Also one important point is that array working_positions = {} in productionsites should start with highest needed worker, because has_workers checks explicitly for first worker (and only first one). Or is there better way how has_workers can say which worker is experienced and must be tested for presence and which can be directly created from working tool in warehouse?

Let me know.

Also I hope reordering in working_positions will not hurt anything. (If there is way how to distinguish experienced workers from novices, this will not be needed, of course)

[TiborB (tiborb95)]

worker has is_buildable() flag, so perhaps this can be used to filter out novices from experienced (upgraded) workers. I will test it...

[GunChleoc (gunchleoc)]

In WorkerDescr, we have a property

becomes_

We could add another property

upgraded_from_

and initialize it with INVALID_INDEX.

This information could then be added to the WorkerDescr in

Tribes::postload()

We could then have a function

WorkerDescr::is_upgraded() {
   return upgraded_from_ != INVALID_INDEX;
}

Would this help?

I am actually not that familiar with the working position functions and produced some bugs there in the one_tribe branch, so there might still be a regression that we have ovelooked.

[TiborB (tiborb95)]

I have coded something, it seems that is_buildable() is good for this test.

[GunChleoc (gunchleoc)]

Excellent :)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.