editor gives error on saving maps

Bug #1509172 reported by king of nowhere
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Critical
Unassigned

Bug Description

This bug was introduced somewhere between 7525 and 7557 for windows.

whenever i try to save the map, i get the message

Error saving map!
Saved map file may be corrupt!
Reason given:
[c:/data/bzr/widelands/working/src/io/filesystem/layered_filesystem.cc:234 ] LayeredFileSystem: unable to create sub filesystem

However, the game attempts to create a saved game file, as [name].wtf.tmp. If I manually rename the file as a .wtf, The editor can open that file without problem. apparently, no information was lost.

If one attempts to create a new save with the name of a .wtf.tmp file, the editor will give an error message and tell that the old file must be deleted manually. If one tries to overwrite an old .wtf file, the game will apparently comply, however the game is not saved and the old saved game is not modified.

Tags: windows

Related branches

GunChleoc (gunchleoc)
Changed in widelands:
importance: Undecided → Critical
milestone: none → build19-rc1
Revision history for this message
SirVer (sirver) wrote :

Is this still current? I recently did changes to the filesystem code, maybe I accidentally fixed it :)

Changed in widelands:
status: New → Incomplete
Revision history for this message
king of nowhere (lainluigi86) wrote :

It was still current as later as version 7695, which is less than two weeks old. I am surprised, this bug has been reported three months ago.

Revision history for this message
kaputtnik (franku) wrote :

king of nowhere, could you please investigate this bug a bit more? F.e.

- Saving maps only in subfolders fail, not in main folder
- Since revision 7770 the failure message should contain the directory name

tags: added: windows
Revision history for this message
kaputtnik (franku) wrote :
Tino (tino79)
Changed in widelands:
status: Incomplete → Confirmed
Revision history for this message
king of nowhere (lainluigi86) wrote :

I downloaded the latest version (7826) and tried kaputtnik suggestion. as he said, the error message is more complete. Now it also says it tried the following paths:
 c:usersluigi.widelandsmaps/out of the desert
, and
c:widelands7826datamaps/out of the desert
(out of the desert is the map I'm currently working on; I expect to post it in a moth or two). I see that the destination names are wrong: first of all, the punctuation lacks a few /. It could, of course, just be a mistake of the error message. Then, I have the italian version of windows, so the folder is named utenti, not users Again, not sure it is relevant; some folders are programmed to be accessed with different names in different languages.
I also tried to make a subfolder and save the map there, but it still gives the error message. the error message is updated to add "subfolder" to the address string. Again, the punctuation is lacking /, and again I have no idea if it is relevant.

Revision history for this message
GunChleoc (gunchleoc) wrote :

This bug is definitely not in the error message, but in the path that Widelands it trying to actually use.

Thanks for the info, we now have a chance to track this down :)

GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

I still have no idea why the backslashes get stripped off the path. Log output attached.

GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → Tino (tino79)
Revision history for this message
GunChleoc (gunchleoc) wrote :

This is now working mostly - I have created a new bug report for the remaining problem:

https://bugs.launchpad.net/widelands/+bug/1548932

Changed in widelands:
assignee: Tino (tino79) → nobody
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.