maybe unused global (pts)

Bug #1502678 reported by H
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Undecided
Unassigned

Bug Description

I saw that in mouse_smoothly_to_pos and wondered if pts is used anywhere outside the function.
https://github.com/widelands/widelands/blob/master/scripting/ui.lua#L229

I used $ ag -rl pts scripting/ but I didn't find a use of it.
Maybe it could be localized (like in line 133).

If you want to get informed about undeclared globals, I think you could use that code
https://github.com/minetest/minetest/blob/master/builtin/common/strict.lua

Tags: cleanups lua
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for pointing out the issue and linking to the code. We definitely need some Lua checking tools - see also https://bugs.launchpad.net/widelands/+bug/1385831

GunChleoc (gunchleoc)
tags: added: cleanups
removed: lowpriority ui.lua
Revision history for this message
GunChleoc (gunchleoc) wrote :
Changed in widelands:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.