"Out of resources" messages should be triggered by productivity

[GunChleoc]

Except for mines, "Out of Resources" messages are triggered by Worker::run_findobject for all production sites.

This is fine for quarries etc (basically, for buildings that have their delay_attempts = 0 in the conf. For other production sites, this is not as useful as it should be.

So, we should hook the triggering of this message into the site's productivity instead.

Related forum topic: https://wl.widelands.org/forum/topic/1733/

[TiborB (tiborb95)]

I would leave it as is but with one modification.

There is m_out_of_resource_delay_counter counter increased by 1 with each notify_player call (when resource is not found). It is zeroed only after publishing the message, when treshold (out_of_resource_delay_attempts, f.e. 10) is achieved.

For productionsites with non-renewable resources (stones, fish, undeground raw materials) - it is fine, but farmers, cutters have renewable/reappearable resources. So I suggest to just to zero the counter when a resource is found (unnotify_player() is called).

Should not have negative impact on mines and alike....

I am running some tests, it looks that is works as intended....

[GunChleoc (gunchleoc)]

Your suggestion will mean that for farms etc. the message would never be triggered, unless there is no room for fields at all.

Mines have their own code anyway and are not affected by this.

[TiborB (tiborb95)]

There is some strict mathematics behind this, but farms will get that message very rarely, f.e. if they are completely surrounded by obstacles.

Mines ARE affected by this, I set up some printf to test it...

[TiborB (tiborb95)]

or rather 'controlled by this code' I would say

[GunChleoc (gunchleoc)]

Mines have a completely separate code. Their "Out of resources" message is triggered within the productionsite/production program itself. The message itself is the same, but what causes the message to be sent is different. Check ActMine in the production program.

For the other productionsites, the trigger is the worker instead of the building. I think we should still keep this as the basic trigger, but instead of having a delay counter, we should check if the productivity is below a certain threshold and falling. If the productivity is low enough, the message will be sent. If not, no message. We can probably steal some code from the statistics strings here. For Quarries and Fishers, we could set this threshold to 100%, so the message gets sent out the first time the worker doesn't find anything.

When I implemented the message for farms etc about a year ago, my skills weren't good enough to make anything but this delay counter, which has never been optimal. Now I think I can do better :)

[TiborB (tiborb95)]

I was looking at Worker::run_findobject() function and ProductionSite::notify_player() subsequently.

I see our opinions (about solution) differs a bit so I am not going to work on it. Anyway, the problem is rather cosmetic then serious...

[GunChleoc (gunchleoc)]

I have created a second branch that implements Tibor's suggestion. Let's discuss in the forum which solution we prefer.

[TiborB (tiborb95)]

fix pushed in revision 7479. Now the message is triggered if site's performance is below a treshold.

[SirVer (sirver)]

Fixed the regression test error related to this change in r7480.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.