Collectors message contains bad names
Bug #1451977 reported by
Albert Einstein
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
High
|
Unassigned |
Bug Description
To reproduce:
1. Begin the game in Collectors mode in any language (including English!)
2. Wait for the first message
3. Read
You will see that the names should be (for example) "Wood lance", not "wood_lance". In other languages it would be "Drewniana lanca" instead of "wood_lance".
So the names are hardcoded, not taken from wares names.
Related branches
lp:~widelands-dev/widelands/bug-1451977
- TiborB: Approve
-
Diff: 15 lines (+2/-1)1 file modifiedscripting/win_conditions/collectors.lua (+2/-1)
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for reporting.
I see the same thing here with r7453.
>So the names are hardcoded, not taken from wares names.
Sorta. Wares have two names, an internal one and a display name. The internal name is always the same so it can be uniquely identified and compared regardless of language chosen. The display name is the translatable one which is (or should at least) be shown in the currently selected language.
For any text shown to players, including these messages the display names should be used. I'm fairly sure this used to be the case too.