Game over window (at 4:00:00) crashes the game

[TiborB]

When testing current trunk (plus own changes) - network game crashed, completely without my intervention, with output:

NetHost::report_result(2, 0, win_condition=Collectors;win_condition_version=2;tribe=atlanteans;score=2)
widelands: /var/widelands/BZR/militarysites_tweaks/src/ui_basic/table.h:203: void* UI::Table<void*>::operator[](uint32_t) const: Assertion `i < m_entry_records.size()' failed.

I saw that the crash happened exactly at 4:00:00 (gdb preserved the screen), I encountered it 3 times but dont know what was the cause.

[Hans Joachim Desserud (hjd)]

If you find out what triggers it, please check whether it happens in trunk too.

[TiborB (tiborb95)]

I am working on changes in AI and I believe there is no relation to my changes. But if it repeats I will provide all info I have.

[TiborB (tiborb95)]

I got a backtrace - attached...

[Hans Joachim Desserud (hjd)]

There were some changes to collectors recently (bug 1418151 and bug 1434291), has someone tested it after both of those were committed? Is it limited to collectors or are all win conditions which show end game screens affected.

Somewhat related, is the test framework able to deal with dialogs and assert they contain some expected content? In other words, would it be possible to set up a save game at 3:59:00, let it run for a while and assert the end game summary is correctly calculated and displayed?

[Hans Joachim Desserud (hjd)]

And thanks for attaching the backtrace :)

[SirVer (sirver)]

I did test it, but apparently I missed something here :/.

> Somewhat related, is the test framework able to deal with dialogs and assert they contain some expected content?

Yes, through UI scripting this is possible for some elements. I think UI tables are not wrapped for Lua, but text areas, buttons and other elements are.

[GunChleoc (gunchleoc)]

Possible duplicate with savegame for testing: https://bugs.launchpad.net/widelands/+bug/1452054

[TiborB (tiborb95)]

I would say the root casue is the same as bug-1451147 and then it might be fixed with my branch lp:~widelands-dev/widelands/bug-1451147

[TiborB (tiborb95)]

Possible fix merged in rev 7461, it nobody encounters the problem afterwards we can close this bug.

[SirVer (sirver)]

I am unable to reproduce a crash at r7485, I therefore think tibor is right with his analysis and close this bug. Thanks for taking that off me Tibor!