Editor Player Menu doesn't update tool overlay when player is removed

[GunChleoc]

When defining the players' starting positions in the editor, when the last player was selected and then removed, the tool still shows the color of the now removed player.

[Hans Joachim Desserud (hjd)]

Confirmed in r7438.

When decreasing the number of players available, the color of the tool doesn't change. However clicking on the ground will place the start position for player #1 regardless of how many were available or which one was selected. I guess this is a fallback because a game would need to include at least one player.

Note though, if you reduce the amount of players but don't click on the map to place (the first) player location, re-increasing the number of players will activate the color again and you will be able to place that color as if it had always existed. Some of the suggestions below would break this behaviour.

What would be the expected/least surprising behaviour:
1. Explicitly switch color and player which will be placed to the first one. As happens today, but the selected player is always reverted to the first one, even if the number of players is increased again in the future.
2. Explicitly switch to the closest/highest available player (however to properly describe it). For instance, if you have four players and player4 selected, if you then reduce the amount of players to three, you now have player3 selected. Player3 remains selected if you increase the amount of players again.
3. Something completely different?

[wl-zocker (wl-zocker)]

I expected behavior 2: When the currently selected player does not exist anymore, switch to the highest available player (which should be CurrentlySelected - 1 in every case because only one player can be deleted at once).

I have no problem with the fact that re-increasing the number does not change the selection back: The game should not try to be too smart, and map-makers will seldom do that.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.