labyrinth not giving promotions properly

[king of nowhere]

labirinth is not promoting soldiers even when fully stocked with wares; if it has only one soldier inside, it is more likely to send it out than to promote it.
after some experimenting, I think I got an idea: the labyrinth is programmed to give the promotions in sequence: evade, defense, hp. once it promoted a soldier to evasion 1, it will try to promote to some other stat, sat defence. if there isn't a shield, or if the soldier already has defence 2, the labyrinth will say "cannot promote" and send the soldier away. I am relatively sure because I had 6 soldiers with evade 1 and hp 1 promotions in and no shields, it kicked out the first two and then promoted to evade 2 the third, then it kicked out the next two and promoted to evasion 2 the third again. I think it should be reprogrammed
I attach the replay

[king of nowhere (lainluigi86)]

i think the replay needs two files but i can only attach one.
You can see at 1:14 I complete the labyrinth and i start to train soldiers, they get the promotions evade 1 and hp 1 and leave (one of them the defence 1 too). at 1:29 I manage to put only the soldiers with already the promos inside, and it only promotes one in three, kicking out the other two.

[Teppo Mäenpää (kxq)]

Most if not all buildings (less warehouses and military sites) work like described above. That is not a bug.

Inspect file tribes/atlanteans/labyrinth/conf for details.

You can attach many files by zipping them together.

I cannot view the replay using B18 or bzr7402, so cannot conclude whether it works as intended. With what did you make the files?

Of course, the behavior can be changed also if currently works as intended.

[king of nowhere (lainluigi86)]

I'm not sure if it can be considered a bug, but for sure the labirinth is kicking out soldiers when it has all it needs to promote them. for a discussion on whether this should be fixed or not, https://wl.widelands.org/forum/topic/1650/
then it's up to you developers decidiing if it is a bug or a feature

[Teppo Mäenpää (kxq)]

Could you tell the details, on how to replay the attached replay files? My guess is that those were made with a devel build, but please tell which one; I am not going to try them all.

If it is a bug, I will fix in few days. If you want a full redesign, then it is more work.

The easiest way to make the training sites more stable would be to observer the stall in training per-soldier instead of per-site.

In short, if the training site is fully supplied or almost fully supplied, it does not kick out soldiers that can be trained. When the training fails too often, the trainer gets upset and kicks the soldiers out rather eagerly. This is intentional; Originally I made the training sites more powerful, but in the end I found that the smaller challenge to be less fun.

[king of nowhere (lainluigi86)]

replay was taken with 7367. and you will see that indeed it does kick out soldiers that can be trained.
Again, I'll let you developers decide if it is a bug or a feature.

[Teppo Mäenpää (kxq)]

I cannot view the replay. Could you verify that the file is intact? Anybody else had luck trying the replay?

[king of nowhere (lainluigi86)]

huh, now i cannot view the replay either. weird. i will make another game and produce a replay, when i'll not be too lazy for it.

[Teppo Mäenpää (kxq)]

If you succeed reproducing:

-ZIP the files together before posting here. The unzip tool will tell immediately if the files have corrupted on the way.

- Make note of the commit number.

[Nasenbaer (nasenbaer)]

Setting to incomplete as there was no answer for 8 months

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]