Needs test: Secondary and Third Alternative Tool no longer reset to the first tool if you let go of the button

Bug #1418050 reported by SirVer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Medium
Unassigned

Bug Description

The bug has been fixed, but we still want a test.

SHIFT(hold): selects first alternative tool while pressing
ALT(hold): Selects second alternative tool while pressing

Holding the key do not work as described. You could release the key but the tool doesn't change to its normal state.

I.e.: In case of height tool, pressing shift will leave the tool to decrease height. You have to click on height tool again to get its normal state (increase height).

Tags: editor

Related branches

Revision history for this message
SirVer (sirver) wrote :

This regressed twice already. time to add a test.

Changed in widelands:
status: New → Confirmed
milestone: none → build19-rc1
importance: Undecided → High
tags: added: editor
Revision history for this message
GunChleoc (gunchleoc) wrote :

While working on something else, I noticed that the SDL_KEYUP event isn't being handled, which is at the root of the problem. So, I made a quick branch. Not compiled or tested; so this bug is is still up for grabs until I get around to it.

GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

OK, compiled and tested. This was indeed the problem, so I have made a merge request.

We still need to write a test for this though. I'll be happy to do so if somebody teaches me how.

GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
status: In Progress → Confirmed
GunChleoc (gunchleoc)
description: updated
GunChleoc (gunchleoc)
summary: - Secondary and Third Alternative Tool no longer reset to the first tool
- if you let go of the button
+ Needs test: Secondary and Third Alternative Tool no longer reset to the
+ first tool if you let go of the button
Changed in widelands:
importance: High → Medium
GunChleoc (gunchleoc)
Changed in widelands:
milestone: build19-rc1 → none
Revision history for this message
GunChleoc (gunchleoc) wrote :
Changed in widelands:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.