Windows installer puts string "Widelands" into the version field

[Dirk Heinrichs]

After installing Widelands (build 18) on Windows (8.1, in case it matters), the version field in the list of installed packages shows "Widelands" instead of the version number.

[wl-zocker (wl-zocker)]

I can confirm that this happens on Win7, where the version should be r7322.

[Dirk Heinrichs (dirk-heinrichs)]

Anyway, in fact it was an update and I didn't refresh the list afterwards. The string "Widelands" was from build 17. It now shows "Widelands build-18", which also isn't exactly a version number, but better than before.

[Hans Joachim Desserud (hjd)]

My hunch is that this is the value defined by VerName in utils/win32/innosetup/Widelands.iss. I'm not familiar with these attributes though, so I don't know the difference between VerName and VerNumber, nor what they are supposed to be set to for an application.

Regarding #1, I don't think it picks version number based on the bzr revision. Maybe it should, though that makes it harder to tell which is the newest of a development build and a stable one. (Unless you combine them in some way, for instance build18+r1234 to signify development releases post-build18.)

[wl-zocker (wl-zocker)]

When I start Widelands, it says Widelands bzr7322[trunk](Release) (using Tino's build), so the bzr number is defined somewhere. If this number can be autogenerated, it would be nice to show the exact revision, otherwise just something like 0.18 would be sufficient.

[Tino (tino79)]

You are mixing up some different meanings here:
We have a build version which depends dynamically on the bzr revision. Widelands shows this on the window bar, main menu and e.g. when you join the multiplayer lobby. I also use this for tagging the installer file name for my dev builds.

The other thing is the release version, which is currently "build-18". At some point we will release "build-19rcX" and "build-19". For these, not the bzr revision will be used, but a static version string.

Because i do have to change it manually, i defenitely won't change the version for the inno installer for each bzr build in my dev builds. The moment you start widelands, the main window shows the exact build version.

Second, "Widelands build-18" is a perfectly fine version string and reflects the current version naming style of widelands. A version is not necessary just a number. There should be some old discussion on the mailing list why widelands does it this way and we are currently at "build-18" and not "0.18".

My vote goes to close this bug.

[Tino (tino79)]

Ah, i forgot:
We dont't also change the $AppID for each windows build (bzr builds and releases). The installer uses this to identify the app during install. So nobody can install 2 different versions on the same system.

[wl-zocker (wl-zocker)]

> Because i do have to change it [the version number] manually, i defenitely won't change the version for the inno installer for each bzr build in my dev builds.

That is what I did not know. It was just an idea, but obviously not viable.

> Second, "Widelands build-18" is a perfectly fine version string

I only see "Widelands" in the list (we're talking about "Uninstall or change programs", aren't we?), both as name and as version. That might be because I have several versions of Widelands on my computer (build17, build 18 and the current nightly) and only one entry in the list. Or is the version taken from the latest installation (the nightly), which does not have a number?

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.