widelands

Fullscreen Toggle Text Overlay

Bug #1397302 reported by Tino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build19-rc1

Bug Description

When toggling fullscreen with F, not all text elements are moved correctly:

- Game speed and chat text stay in their position relative to upper left
- Map position (debug builds) moves correctly to lower right corner in fullscreen

Related branches

lp:~widelands-dev/widelands/move_mapview_children
Tino: Approve
GunChleoc: Approve
Diff: 400 lines (+91/-109)
8 files modified
src/wui/chatoverlay.cc (+4/-0)
src/wui/chatoverlay.h (+3/-0)
src/wui/interactive_base.cc (+33/-100)
src/wui/interactive_base.h (+0/-5)
src/wui/interactive_gamebase.cc (+49/-0)
src/wui/interactive_gamebase.h (+2/-0)
src/wui/interactive_player.cc (+0/-2)
src/wui/interactive_spectator.cc (+0/-2)
Revision history for this message
GunChleoc (gunchleoc) wrote :

I think this is Windows only, because it's fine on my Ubuntu.

Revision history for this message
SirVer (sirver) wrote :

I can reproduce on Mac OS and I am fairly certain that it must happen on linux too.

fix is: MapView is already listening to GraphicResolutionsChanged events and must simply reposition all of it's children accordingly. I only did it for the toolbar since I did not try chat and did not have the numbers on.

Revision history for this message
Gabriel Margiani (gamag) wrote :

On ArchLinux with i3 window manager, I can't reproduce it. strange.

SirVer (sirver)
Changed in widelands:
importance: Undecided → Low
status: New → Confirmed
assignee: nobody → SirVer (sirver)
status: Confirmed → In Progress
milestone: none → build19-rc1
Revision history for this message
SirVer (sirver) wrote :

Fixed in r7291.

Changed in widelands:
status: In Progress → Fix Committed
assignee: SirVer (sirver) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.